Skip to content

chore: add macos to tesing #1741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
crozzy wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

chore: add macos to tesing #1741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2130b31
ci: have a dedicated job to test platform specific tests
crozzy Jan 23, 2026
007bdb1
fetcher: give tmpfile ability to create
crozzy Jan 27, 2026
19f68ac
fetcher: reopen_other use path relative to root
crozzy Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ jobs:
printf '%s/%s/actions/runs/%s/attempts/%s\n'\
"${GITHUB_SERVER_URL}" "${GITHUB_REPOSITORY}" "${GITHUB_RUN_ID}" "${GITHUB_RUN_ATTEMPT}"\
> ~/ok-by-run
find . -name .git -prune -o -name testdata -prune -o -name go.mod -printf '%h\n' |
find . -name .git -prune -o -name testdata -prune -o -name go.mod -print | xargs -n1 dirname |
while read -r dir; do (
cd "$dir"
go list -m
Expand All @@ -133,3 +133,22 @@ jobs:
sudo journalctl --unit postgresql.service --boot -0
ls /var/log/postgresql/postgresql-*.log
sudo cat /var/log/postgresql/postgresql-*.log

platform-tests:
name: Platform Tests
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os:
- macos-latest
steps:
- name: Checkout
uses: actions/checkout@v6
with:
persist-credentials: false
- uses: actions/setup-go@v6
with:
go-version: stable
- name: Test Fetcher
run: go test -race -v -run TestFetch ./libindex/
7 changes: 5 additions & 2 deletions libindex/reopen_other.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,11 @@

package libindex

import "os"
import (
"os"
"path/filepath"
)

func reopen(dir *os.Root, f *os.File) (*os.File, error) {
return dir.OpenFile(f.Name(), os.O_RDONLY, 0o644)
return dir.OpenFile(filepath.Base(f.Name()), os.O_RDONLY, 0o644)
}
1 change: 1 addition & 0 deletions libindex/tempfile_linux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ Loop:
flag := os.O_WRONLY
if !tmpOK {
name = fetchFilename()
flag |= os.O_CREATE | os.O_EXCL // Create new file, fail if exists
} else {
flag |= unix.O_TMPFILE
}
Expand Down
2 changes: 1 addition & 1 deletion libindex/tempfile_unix.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (
)

func openTemp(dir *os.Root) (f *os.File, err error) {
const flag = os.O_WRONLY
const flag = os.O_WRONLY | os.O_CREATE | os.O_EXCL
for {
name := fetchFilename()
f, err = dir.OpenFile(name, flag, 0o644)
Expand Down
2 changes: 1 addition & 1 deletion libindex/tempfile_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import (
func openTemp(dir *os.Root) (f *os.File, err error) {
// Copied out of golang.org/x/sys/windows
const FILE_FLAG_DELETE_ON_CLOSE = 0x04000000
const flag = os.O_WRONLY | FILE_FLAG_DELETE_ON_CLOSE
const flag = os.O_WRONLY | os.O_CREATE | os.O_EXCL | FILE_FLAG_DELETE_ON_CLOSE
for {
name := fetchFilename()
f, err = dir.OpenFile(name, flag, 0o644)
Expand Down