Drop per-field enableCppPropsIteratorSetter ternaries from Props ctors

Summary:
With `ConcreteComponentDescriptor::cloneProps` now dispatching to the iterator-setter path via the copy ctor (the prior diffs in the stack), the per-field `flag ? sourceProps.X : convertRawProp(...)` ternaries scattered across every Props copy ctor are dead in the flag-on path (copy ctor handles those fields directly) and redundant in the flag-off path (the runtime check inside the ctor is always false, since cloneProps already filtered the iterator-setter path out before invoking the 3-arg ctor).

Strip the ternary wrapper from every Props .cpp file. Each initializer collapses from

```cpp
field(ReactNativeFeatureFlags::enableCppPropsIteratorSetter()
          ? sourceProps.field
          : convertRawProp(ctx, rawProps, "field", sourceProps.field, default))
```

to just

```cpp
field(convertRawProp(ctx, rawProps, "field", sourceProps.field, default))
```

Also strip:

- `YogaStylableProps`: the inverted `if (!flag) { convertRawPropAliases(...); }` wrapper becomes unconditional.
- `Props::initialize` (`Props.cpp`): the `nativeId` ternary collapses to the `convertRawProp` form.
- `AccessibilityProps` (xplat + react-native-macos): the `if (flag) { copy } else { at()-based resolution }` block in the constructor body collapses to just the `at()`-based resolution — the same reasoning applies (flag-on path never reaches the 3-arg ctor).
- Drop `<react/featureflags/ReactNativeFeatureFlags.h>` includes that are no longer referenced.

311 ternaries removed across 20 Props .cpp files (incl. the `third-party/react-native-macos/` mirror and `xplat/instagram/airwave/components/airwavescrollview/cpp/AirwaveScrollViewProps.cpp`).

Side benefit: the classic path is now meaningfully cheaper because we no longer do `~30 × ReactNativeFeatureFlags::enableCppPropsIteratorSetter()` calls (each goes through `std::atomic<std::optional<bool>>::load()`) per `cloneProps` invocation per Props class.

Changelog:
[Internal]

Differential Revision: D109583086

Author: javache

packages/react-native/ReactCommon/react/renderer/components/image/ImageProps.cpp

@@ -5,7 +5,6 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-#include <react/featureflags/ReactNativeFeatureFlags.h>
 #include <react/renderer/components/image/ImageProps.h>
 #include <react/renderer/components/image/conversions.h>
 #include <react/renderer/core/propsConversions.h>
@@ -19,131 +18,85 @@ ImageProps::ImageProps(
     const RawProps& rawProps)
     : ViewProps(context, sourceProps, rawProps),
       sources(
-          ReactNativeFeatureFlags::enableCppPropsIteratorSetter()
-              ? sourceProps.sources
-              : convertRawProp(
-                    context,
-                    rawProps,
-                    "source",
-                    sourceProps.sources,
-                    {})),
-      defaultSource(
-          ReactNativeFeatureFlags::enableCppPropsIteratorSetter()
-              ? sourceProps.defaultSource
-              : convertRawProp(
-                    context,
-                    rawProps,
-                    "defaultSource",
-                    sourceProps.defaultSource,
-                    {})),
-      loadingIndicatorSource(
-          ReactNativeFeatureFlags::enableCppPropsIteratorSetter()
-              ? sourceProps.loadingIndicatorSource
-              : convertRawProp(
-                    context,
-                    rawProps,
-                    "loadingIndicatorSource",
-                    sourceProps.loadingIndicatorSource,
-                    {})),
-      resizeMode(
-          ReactNativeFeatureFlags::enableCppPropsIteratorSetter()
-              ? sourceProps.resizeMode
-              : convertRawProp(
-                    context,
-                    rawProps,
-                    "resizeMode",
-                    sourceProps.resizeMode,
-                    ImageResizeMode::Stretch)),
-      blurRadius(
-          ReactNativeFeatureFlags::enableCppPropsIteratorSetter()
-              ? sourceProps.blurRadius
-              : convertRawProp(
-                    context,
-                    rawProps,
-                    "blurRadius",
-                    sourceProps.blurRadius,
-                    {})),
-      capInsets(
-          ReactNativeFeatureFlags::enableCppPropsIteratorSetter()
-              ? sourceProps.capInsets
-              : convertRawProp(
-                    context,
-                    rawProps,
-                    "capInsets",
-                    sourceProps.capInsets,
-                    {})),
-      tintColor(
-          ReactNativeFeatureFlags::enableCppPropsIteratorSetter()
-              ? sourceProps.tintColor
-              : convertRawProp(
-                    context,
-                    rawProps,
-                    "tintColor",
-                    sourceProps.tintColor,
-                    {})),
-      internal_analyticTag(
-          ReactNativeFeatureFlags::enableCppPropsIteratorSetter()
-              ? sourceProps.internal_analyticTag
-              : convertRawProp(
-                    context,
-                    rawProps,
-                    "internal_analyticTag",
-                    sourceProps.internal_analyticTag,
-                    {})),
-      resizeMethod(
-          ReactNativeFeatureFlags::enableCppPropsIteratorSetter()
-              ? sourceProps.resizeMethod
-              : convertRawProp(
-                    context,
-                    rawProps,
-                    "resizeMethod",
-                    sourceProps.resizeMethod,
-                    {"auto"})),
-      resizeMultiplier(
-          ReactNativeFeatureFlags::enableCppPropsIteratorSetter()
-              ? sourceProps.resizeMultiplier
-              : convertRawProp(
-                    context,
-                    rawProps,
-                    "resizeMultiplier",
-                    sourceProps.resizeMultiplier,
-                    1)),
-      shouldNotifyLoadEvents(
-          ReactNativeFeatureFlags::enableCppPropsIteratorSetter()
-              ? sourceProps.shouldNotifyLoadEvents
-              : convertRawProp(
-                    context,
-                    rawProps,
-                    "shouldNotifyLoadEvents",
-                    sourceProps.shouldNotifyLoadEvents,
-                    {})),
-      overlayColor(
-          ReactNativeFeatureFlags::enableCppPropsIteratorSetter()
-              ? sourceProps.overlayColor
-              : convertRawProp(
-                    context,
-                    rawProps,
-                    "overlayColor",
-                    sourceProps.overlayColor,
-                    {})),
-      fadeDuration(
-          ReactNativeFeatureFlags::enableCppPropsIteratorSetter()
-              ? sourceProps.fadeDuration
-              : convertRawProp(
-                    context,
-                    rawProps,
-                    "fadeDuration",
-                    sourceProps.fadeDuration,
-                    {})),
-      progressiveRenderingEnabled(
-          ReactNativeFeatureFlags::enableCppPropsIteratorSetter()
-              ? sourceProps.progressiveRenderingEnabled
-              : convertRawProp(
-                    context,
-                    rawProps,
-                    "progressiveRenderingEnabled",
-                    sourceProps.progressiveRenderingEnabled,
-                    {})) {}
+          convertRawProp(context, rawProps, "source", sourceProps.sources, {})),
+      defaultSource(convertRawProp(
+          context,
+          rawProps,
+          "defaultSource",
+          sourceProps.defaultSource,
+          {})),
+      loadingIndicatorSource(convertRawProp(
+          context,
+          rawProps,
+          "loadingIndicatorSource",
+          sourceProps.loadingIndicatorSource,
+          {})),
+      resizeMode(convertRawProp(
+          context,
+          rawProps,
+          "resizeMode",
+          sourceProps.resizeMode,
+          ImageResizeMode::Stretch)),
+      blurRadius(convertRawProp(
+          context,
+          rawProps,
+          "blurRadius",
+          sourceProps.blurRadius,
+          {})),
+      capInsets(convertRawProp(
+          context,
+          rawProps,
+          "capInsets",
+          sourceProps.capInsets,
+          {})),
+      tintColor(convertRawProp(
+          context,
+          rawProps,
+          "tintColor",
+          sourceProps.tintColor,
+          {})),
+      internal_analyticTag(convertRawProp(
+          context,
+          rawProps,
+          "internal_analyticTag",
+          sourceProps.internal_analyticTag,
+          {})),
+      resizeMethod(convertRawProp(
+          context,
+          rawProps,
+          "resizeMethod",
+          sourceProps.resizeMethod,
+          {"auto"})),
+      resizeMultiplier(convertRawProp(
+          context,
+          rawProps,
+          "resizeMultiplier",
+          sourceProps.resizeMultiplier,
+          1)),
+      shouldNotifyLoadEvents(convertRawProp(
+          context,
+          rawProps,
+          "shouldNotifyLoadEvents",
+          sourceProps.shouldNotifyLoadEvents,
+          {})),
+      overlayColor(convertRawProp(
+          context,
+          rawProps,
+          "overlayColor",
+          sourceProps.overlayColor,
+          {})),
+      fadeDuration(convertRawProp(
+          context,
+          rawProps,
+          "fadeDuration",
+          sourceProps.fadeDuration,
+          {})),
+      progressiveRenderingEnabled(convertRawProp(
+          context,
+          rawProps,
+          "progressiveRenderingEnabled",
+          sourceProps.progressiveRenderingEnabled,
+          {})) {}
 
 void ImageProps::setProp(
     const PropsParserContext& context,