Skip to content

Commit a96d7fe

Browse files
coadometa-codesync[bot]
authored andcommitted
Make componentregistry factory and view-name headers for-frameworks (#58874)
Summary: Pull Request resolved: #58874 Lower two `react/renderer/componentregistry` headers from public to "for frameworks": - `ComponentDescriptorFactory.h` - consumed by host integrations that construct the Scheduler or a mounting manager, not by app code, - `componentNameByReactViewName.h` - maps legacy view names to Fabric component names; it is used by platform and library integrations, not by app code. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D123588640 fbshipit-source-id: 328a287600758750851c16ca8b83052038981d4d
1 parent e560782 commit a96d7fe

4 files changed

Lines changed: 3 additions & 4 deletions

File tree

‎packages/react-native/ReactCommon/react/renderer/componentregistry/ComponentDescriptorFactory.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/FrameworksGuard.h>
1111

1212
#include <memory>
1313

‎packages/react-native/ReactCommon/react/renderer/componentregistry/React/ComponentRegistry.h‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,9 @@
3131
#undef RN_UMBRELLA_CONTEXT
3232
#define RN_UMBRELLA_CONTEXT 1
3333

34-
#include <react/renderer/componentregistry/ComponentDescriptorFactory.h>
3534
#include <react/renderer/componentregistry/ComponentDescriptorProvider.h>
3635
#include <react/renderer/componentregistry/ComponentDescriptorProviderRegistry.h>
3736
#include <react/renderer/componentregistry/ComponentDescriptorRegistry.h>
38-
#include <react/renderer/componentregistry/componentNameByReactViewName.h>
3937

4038
#undef RN_UMBRELLA_CONTEXT
4139
#pragma pop_macro("RN_UMBRELLA_CONTEXT")

‎packages/react-native/ReactCommon/react/renderer/componentregistry/componentNameByReactViewName.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/FrameworksGuard.h>
1111

1212
#include <string>
1313

‎packages/react-native/ReactCommon/react/renderer/scheduler/SchedulerToolbox.h‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
#include <React/RuntimeExecutor.h>
1717
#include <React/Utils.h>
1818
#include <react/renderer/animationbackend/AnimationChoreographer.h>
19+
#include <react/renderer/componentregistry/ComponentDescriptorFactory.h>
1920
#include <react/renderer/uimanager/UIManagerCommitHook.h>
2021
#include <react/renderer/uimanager/primitives.h>
2122

0 commit comments

Comments
 (0)