Skip to content

Commit b364490

Browse files
zeyapmeta-codesync[bot]
authored andcommitted
Undo featureflag default true & promote to canary instead, enable for Meta overrides (#57372)
Summary: Pull Request resolved: #57372 ## Changelog: [Internal] - Undo featureflag default true & promote to canary instead, enable for Meta overrides We need more discussion about testing in canary before release. Since 0.87 cut is coming soon, let's not enable the flag for 0.87 just yet Reviewed By: javache, rubennorte Differential Revision: D110053624 fbshipit-source-id: 2ec1093555410a8944509e7f94e59b4682e78dd9
1 parent e442c49 commit b364490

8 files changed

Lines changed: 18 additions & 18 deletions

File tree

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<4c0b09eb9df8e4580dc4778a91591236>>
7+
* @generated SignedSource<<4227353cb809dac40fe70d83154ba2bc>>
88
*/
99

1010
/**
@@ -27,7 +27,7 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi
2727

2828
override fun cdpInteractionMetricsEnabled(): Boolean = false
2929

30-
override fun cxxNativeAnimatedEnabled(): Boolean = true
30+
override fun cxxNativeAnimatedEnabled(): Boolean = false
3131

3232
override fun defaultTextToOverflowHidden(): Boolean = true
3333

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsOverrides_RNOSS_Canary_Android.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<0642a793f11832205a362e6d1ae6e081>>
7+
* @generated SignedSource<<d0524c8293f029992b78e4f9479b8a1d>>
88
*/
99

1010
/**
@@ -23,6 +23,8 @@ public open class ReactNativeFeatureFlagsOverrides_RNOSS_Canary_Android : ReactN
2323
// We could use JNI to get the defaults from C++,
2424
// but that is more expensive than just duplicating the defaults here.
2525

26+
override fun cxxNativeAnimatedEnabled(): Boolean = true
27+
2628
override fun enableAccessibilityOrder(): Boolean = true
2729

2830
override fun enableBridgelessArchitecture(): Boolean = true

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsOverrides_RNOSS_Experimental_Android.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<21e8d5e2a4a37e0a51f25609b80f4924>>
7+
* @generated SignedSource<<7103d9c2fa3e2f152ce60b5dff12c0e4>>
88
*/
99

1010
/**
@@ -23,8 +23,6 @@ public open class ReactNativeFeatureFlagsOverrides_RNOSS_Experimental_Android :
2323
// We could use JNI to get the defaults from C++,
2424
// but that is more expensive than just duplicating the defaults here.
2525

26-
override fun cxxNativeAnimatedEnabled(): Boolean = true
27-
2826
override fun enableFlexboxAutoMinSizeInStrictMode(): Boolean = true
2927

3028
override fun enableRuntimeSchedulerQueueClearingOnError(): Boolean = true

packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsDefaults.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<6451b9c50b78b3b00fc74b137f5ca541>>
7+
* @generated SignedSource<<d466be4c46ae5939d812dbbc5e7799b5>>
88
*/
99

1010
/**
@@ -36,7 +36,7 @@ class ReactNativeFeatureFlagsDefaults : public ReactNativeFeatureFlagsProvider {
3636
}
3737

3838
bool cxxNativeAnimatedEnabled() override {
39-
return true;
39+
return false;
4040
}
4141

4242
bool defaultTextToOverflowHidden() override {

packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsOverridesOSSCanary.h

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<72ef3ea85f4833a96fe222950d16278b>>
7+
* @generated SignedSource<<5d286510a4f8642adcc9d38556dd60dd>>
88
*/
99

1010
/**
@@ -27,6 +27,10 @@ class ReactNativeFeatureFlagsOverridesOSSCanary : public ReactNativeFeatureFlags
2727
public:
2828
ReactNativeFeatureFlagsOverridesOSSCanary() = default;
2929

30+
bool cxxNativeAnimatedEnabled() override {
31+
return true;
32+
}
33+
3034
bool enableAccessibilityOrder() override {
3135
return true;
3236
}

packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsOverridesOSSExperimental.h

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<e4a9f907d9bcfa0e84f8dbcf5b1dc2be>>
7+
* @generated SignedSource<<7341b28bb77aeeec670051149faeae04>>
88
*/
99

1010
/**
@@ -27,10 +27,6 @@ class ReactNativeFeatureFlagsOverridesOSSExperimental : public ReactNativeFeatur
2727
public:
2828
ReactNativeFeatureFlagsOverridesOSSExperimental() = default;
2929

30-
bool cxxNativeAnimatedEnabled() override {
31-
return true;
32-
}
33-
3430
bool enableFlexboxAutoMinSizeInStrictMode() override {
3531
return true;
3632
}

packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,15 +72,15 @@ const definitions: FeatureFlagDefinitions = {
7272
ossReleaseStage: 'none',
7373
},
7474
cxxNativeAnimatedEnabled: {
75-
defaultValue: true,
75+
defaultValue: false,
7676
metadata: {
7777
dateAdded: '2025-03-14',
7878
description:
7979
'Use a C++ implementation of Native Animated instead of the platform implementation.',
8080
expectedReleaseValue: true,
8181
purpose: 'experimentation',
8282
},
83-
ossReleaseStage: 'experimental',
83+
ossReleaseStage: 'canary',
8484
},
8585
defaultTextToOverflowHidden: {
8686
defaultValue: true,

packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<1a333a44919efce6bb2070bae79bdf9b>>
7+
* @generated SignedSource<<5e80ae1ef75d1fbf51fd94cd5495157f>>
88
* @flow strict
99
* @noformat
1010
*/
@@ -220,7 +220,7 @@ export const cdpInteractionMetricsEnabled: Getter<boolean> = createNativeFlagGet
220220
/**
221221
* Use a C++ implementation of Native Animated instead of the platform implementation.
222222
*/
223-
export const cxxNativeAnimatedEnabled: Getter<boolean> = createNativeFlagGetter('cxxNativeAnimatedEnabled', true);
223+
export const cxxNativeAnimatedEnabled: Getter<boolean> = createNativeFlagGetter('cxxNativeAnimatedEnabled', false);
224224
/**
225225
* When enabled, sets the default overflow style for Text components to hidden instead of visible.
226226
*/

0 commit comments

Comments
 (0)