fix(spm): Flow/ESLint/Prettier compliance for the SPM tooling

The newer toolchain on the rebased base flags deprecated Flow utility
types and a few lint nits in the SPM scripts + test library:

- Flow: `$ReadOnly`/`$ReadOnlyArray`/`$ReadOnlySet` -> `Readonly*`,
  `$Shape` -> `Partial`, `mixed` -> `unknown`, `+` variance sigil ->
  `readonly`; narrow the nullable remote-package config before reading
  `.url`/`.version` (the `plan.isRemote` branch didn't refine it).
- ESLint: sort requires in expand-spm-dependencies.js and the two
  react-native-test-library entrypoints; drop unnecessary `\"` escapes
  in generate-spm-autolinking-test.js.
- Prettier formatting on spm-pbxproj.js.

No behavior change; 349 scripts/spm tests still green.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: chrfalch

packages/react-native-test-library/apple/index.js

@@ -12,8 +12,8 @@
 
 import type {Greeting} from 'react-native-test-library-common';
 
-import {formatGreeting} from 'react-native-test-library-common';
 import {NativeModules, Platform} from 'react-native';
+import {formatGreeting} from 'react-native-test-library-common';
 
 export function greet(g: Greeting): Promise<string> {
   const TestLibraryApple = NativeModules.TestLibraryApple;

packages/react-native-test-library/common/index.js

@@ -12,7 +12,7 @@
 
 import {NativeModules, Platform} from 'react-native';
 
-export type Greeting = $ReadOnly<{
+export type Greeting = Readonly<{
   name: string,
   language: string,
 }>;

packages/react-native/scripts/spm/__tests__/generate-spm-autolinking-test.js

@@ -256,7 +256,7 @@ describe('generateSynthPackageSwift', () => {
     );
     // No header-search-path vars, no flags, no legacy VFS machinery.
     expect(result).not.toContain('rnCoreHeaders');
-    expect(result).not.toContain('unsafeFlags([\"-I\"');
+    expect(result).not.toContain('unsafeFlags(["-I"');
     expect(result).not.toContain('ReactHeadersAll');
     expect(result).not.toContain('-ivfsoverlay');
     expect(result).not.toContain('let xcfwHeaders');

packages/react-native/scripts/spm/expand-spm-dependencies.js

@@ -11,6 +11,8 @@
 'use strict';
 
 const {toSwiftName} = require('./spm-utils');
+const fs = require('fs');
+const path = require('path');
 
 /**
  * expand-spm-dependencies.js — Resolves transitive native deps declared via
@@ -34,9 +36,6 @@ const {toSwiftName} = require('./spm-utils');
  * testable.
  */
 
-const fs = require('fs');
-const path = require('path');
-
 /*::
 import type {AutolinkedDep} from './spm-types';
 

packages/react-native/scripts/spm/generate-spm-autolinking.js

@@ -215,7 +215,7 @@ function inferPublicHeadersPath(sourcePath /*: string */) /*: string | null */ {
 }
 
 /*::
-type ExtensionFilter = $ReadOnlySet<string>;
+type ExtensionFilter = ReadonlySet<string>;
 */
 
 const HEADER_EXTENSIONS /*: ExtensionFilter */ = new Set(['.h', '.hpp']);
@@ -234,7 +234,7 @@ const ALL_SOURCE_EXTENSIONS /*: ExtensionFilter */ = new Set([
 // Directory names whose contents should never be included in an SPM target —
 // test fixtures, Android sources, vendored modules. Shared between the source
 // walker and the header linker so they agree on what to skip.
-const SKIP_DIRS_DEFAULT /*: $ReadOnlySet<string> */ = new Set([
+const SKIP_DIRS_DEFAULT /*: ReadonlySet<string> */ = new Set([
   'android',
   'tests',
   '__tests__',
@@ -767,8 +767,8 @@ function autolinkingDepToSpmTarget(
 function generateAutolinkedPackageSwift(
   input /*: AggregatorInput */,
 ) /*: string */ {
-  const npmDeps /*: $ReadOnlyArray<NpmDepRef> */ = input.npmDeps ?? [];
-  const inlineTargets /*: $ReadOnlyArray<SpmTarget> */ =
+  const npmDeps /*: ReadonlyArray<NpmDepRef> */ = input.npmDeps ?? [];
+  const inlineTargets /*: ReadonlyArray<SpmTarget> */ =
     input.inlineTargets ?? [];
   const hasReactDep /*: boolean */ = input.hasReactDep !== false;
   // Relative path from autolinked/ to build/xcframeworks/, e.g. "../build/xcframeworks".

packages/react-native/scripts/spm/generate-spm-xcodeproj.js

@@ -763,7 +763,7 @@ function injectSpmIntoPbxproj(
   // 1. Insert the new objects (skip any UUID already present — idempotency).
   const insertObjects = (
     sectionName /*: string */,
-    objs /*: $ReadOnlyArray<{+uuid: string, +comment?: ?string, +fields: {+[string]: string}, ...}> */,
+    objs /*: ReadonlyArray<{readonly uuid: string, readonly comment?: ?string, readonly fields: {readonly [string]: string}, ...}> */,
   ) => {
     const fresh = objs.filter(o => !text.includes(o.uuid));
     for (const o of objs) {

packages/react-native/scripts/spm/read-podspec.js

@@ -32,7 +32,7 @@ const fs = require('fs');
 const path = require('path');
 
 /*::
-type RawSpec = {[string]: mixed};
+type RawSpec = {[string]: unknown};
 */
 
 // ---------------------------------------------------------------------------
@@ -380,7 +380,7 @@ function flattenSubspecs(rawSpec /*: RawSpec */) /*: PodspecModel */ {
   const partial /*: boolean */ = rawSpec.__regex_partial__ === true;
   if (Array.isArray(rawSpec.__warnings__)) {
     // $FlowFixMe[incompatible-type] runtime-validated dynamic shape
-    const rawWarnings /*: $ReadOnlyArray<string> */ = rawSpec.__warnings__;
+    const rawWarnings /*: ReadonlyArray<string> */ = rawSpec.__warnings__;
     for (const w of rawWarnings) {
       warnings.push(w);
     }
@@ -598,7 +598,7 @@ function flattenSubspecs(rawSpec /*: RawSpec */) /*: PodspecModel */ {
   }
 
   // $FlowFixMe[prop-missing] dynamic shape
-  const reqArc /*: mixed */ = rawSpec.requires_arc;
+  const reqArc /*: unknown */ = rawSpec.requires_arc;
   const requiresArc =
     reqArc === false || (Array.isArray(reqArc) && reqArc.length === 0)
       ? false

packages/react-native/scripts/spm/scaffold-package-swift.js

@@ -122,7 +122,7 @@ const SCAFFOLD_PREFIX_HEADER_CONTENTS = `// AUTO-SCAFFOLDED by react-native spm
 // Names of deps the scaffolder always refuses to touch — `react-native`
 // itself is handled by the xcframework subpackage, never as an autolinked
 // target.
-const NEVER_SCAFFOLD /*: $ReadOnlySet<string> */ = new Set(['react-native']);
+const NEVER_SCAFFOLD /*: ReadonlySet<string> */ = new Set(['react-native']);
 
 // React-core / React-Fabric / etc. dependency names collapse to a single
 // `.product(name: "ReactNative", package: "ReactNative")` reference because
@@ -980,7 +980,7 @@ type ScaffoldAllOptions = {
   // npm dep names to skip entirely — used when the user declined the
   // confirmation prompt for first-time scaffolds. Skipped deps still
   // appear in the returned results array with status='skipped-opt-out'.
-  skipDeps?: $ReadOnlyArray<string>,
+  skipDeps?: ReadonlyArray<string>,
 };
 */
 

packages/react-native/scripts/spm/spm-pbxproj.js

@@ -43,7 +43,7 @@ function quoteIfNeeded(s /*: string */) /*: string */ {
  * entries into an existing project.
  */
 function serializeEntry(
-  entry /*: {+uuid: string, +comment?: ?string, +fields: {+[string]: string}, ...} */,
+  entry /*: {readonly uuid: string, readonly comment?: ?string, readonly fields: {readonly [string]: string}, ...} */,
 ) /*: string */ {
   const comment =
     entry.comment != null && entry.comment !== ''
@@ -334,12 +334,14 @@ function addArrayMembers(
   text /*: string */,
   obj /*: BodyRange */,
   key /*: string */,
-  members /*: $ReadOnlyArray<{+uuid: string, +comment?: ?string, ...}> */,
+  members /*: ReadonlyArray<{readonly uuid: string, readonly comment?: ?string, ...}> */,
   options /*: {prepend?: boolean} */ = {},
 ) /*: string */ {
   const fieldIndent = detectFieldIndent(text, obj);
   const memberIndent = fieldIndent + '\t';
-  const line = (m /*: {+uuid: string, +comment?: ?string, ...} */) =>
+  const line = (
+    m /*: {readonly uuid: string, readonly comment?: ?string, ...} */,
+  ) =>
     `${memberIndent}${m.uuid}${m.comment != null && m.comment !== '' ? ` /* ${m.comment} */` : ''},\n`;
 
   const field = findField(text, obj, key);
@@ -460,7 +462,7 @@ function removeObjectByUuid(
  */
 function removeArrayMembersByUuid(
   text /*: string */,
-  uuids /*: $ReadOnlyArray<string> */,
+  uuids /*: ReadonlyArray<string> */,
 ) /*: string */ {
   let out = text;
   for (const uuid of uuids) {
@@ -495,7 +497,7 @@ function removeArrayStringValues(
   text /*: string */,
   obj /*: BodyRange */,
   key /*: string */,
-  values /*: $ReadOnlyArray<string> */,
+  values /*: ReadonlyArray<string> */,
 ) /*: string */ {
   const f = findField(text, obj, key);
   if (f == null) {

packages/react-native/scripts/spm/spm-types.js

@@ -182,8 +182,8 @@ export type NpmDepRef = {
 };
 
 export type AggregatorInput = {
-  npmDeps?: $ReadOnlyArray<NpmDepRef>,
-  inlineTargets?: $ReadOnlyArray<SpmTarget>,
+  npmDeps?: ReadonlyArray<NpmDepRef>,
+  inlineTargets?: ReadonlyArray<SpmTarget>,
   hasReactDep?: boolean,
   // Relative path from the aggregator's dir (autolinking/) to
   // build/xcframeworks. Used for the inline-target ReactNative dep.