Remove TextInput blurOnSubmit#57393
Open
zoontek wants to merge 1 commit into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
facebook-github-tools
Bot
added
the
Shared with Meta
Contributor
|
Please rebase. |
zoontek
force-pushed
the
remove-textinput-blur-on-submit
branch
2 times, most recently
from
6622940 to
1922fe8
Compare
Contributor
Author
|
@rozele ✅ |
# Conflicts: # packages/react-native/ReactNativeApi.d.ts # Conflicts: # packages/react-native/ReactNativeApi.d.ts # Conflicts: # packages/react-native/ReactNativeApi.d.ts
zoontek
force-pushed
the
remove-textinput-blur-on-submit
branch
from
1922fe8 to
ac45f41
Compare
|
@Abbondanzo has imported this pull request. If you are a Meta employee, you can view this in D110336776. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Removes the
blurOnSubmitTextInput prop, deprecated since 0.77 in favor ofsubmitBehavior. Cleans it from the JS API, types, native component spec, and rn-tester examples. Default behavior is unchanged: single-line inputs blur and submit, multiline inputs insert a newline.See #57384
Changelog:
[GENERAL] [REMOVED] - Remove deprecated
TextInputblurOnSubmitprop (usesubmitBehaviorinstead)Test Plan:
yarn flow checkpassesyarn build-typesregenerates the API snapshot withoutblurOnSubmitsubmitBehaviorvalues