Repository navigation
Include preset dependencies in main cache keys - #58251
Closed
OskarEichler wants to merge 1 commit into
Closed
OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
|
@vzaidman has imported this pull request. If you are a Meta employee, you can view this in D118440621. |
shashikant-panchal
pushed a commit
to shashikant-panchal/react-native
that referenced
this pull request
Sep 10, 2026
Summary: Development `-main` builds compute the Babel preset transformer cache key from preset JavaScript sources, but omit `package.json`. React Native regularly updates parser and Babel plugin dependencies without changing those source files, so a dependency-only update can preserve the cache key and reuse transforms produced by an older dependency set. Include the preset package metadata bytes in the existing MD5 input. This adds one small file read only to the memoized `-main` slow path; published releases remain keyed directly by their immutable package version. ## Changelog: [INTERNAL] [FIXED] - Invalidate React Native Babel preset development caches when dependency metadata changes. Pull Request resolved: react#58251 Test Plan: - Added an isolated-module regression that supplies two package metadata contents with identical preset source contents; pristine main returns the same key, while the fix returns different keys. - Full preset Jest passes: 5/5 suites, 111/111 tests, 16 snapshots. - Fresh Flow check reports 0 errors. - Targeted no-ignore ESLint, Prettier, and `git diff --check` pass. No transform output, public API, published-release cache behavior, or UI changes. Reviewed By: christophpurrer Differential Revision: D118440621 Pulled By: vzaidman fbshipit-source-id: 21d4df2d5bc0428d6cf2138b2f5230d777b7ddb0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Development
-mainbuilds compute the Babel preset transformer cache key from preset JavaScript sources, but omitpackage.json. React Native regularly updates parser and Babel plugin dependencies without changing those source files, so a dependency-only update can preserve the cache key and reuse transforms produced by an older dependency set.Include the preset package metadata bytes in the existing MD5 input. This adds one small file read only to the memoized
-mainslow path; published releases remain keyed directly by their immutable package version.Changelog:
[INTERNAL] [FIXED] - Invalidate React Native Babel preset development caches when dependency metadata changes.
Test Plan:
git diff --checkpass.No transform output, public API, published-release cache behavior, or UI changes.