Repository navigation
Conversation
Summary: `Device#dangerouslyRecreateDevice` overwrote `#pagesPollingIntervalId` without clearing the previous interval. The old device socket's `close` handler could not clear it either, because its `socket === #deviceSocket` guard fails once reconstruct points `#deviceSocket` at the new socket. Every device ID collision therefore leaked a ref'd 1s `getPages` polling timer: the new device received duplicate polls, and the event loop was kept alive (Jest suites covering device handoff never exited on their own). Clear the previous polling interval before reconstructing. Clearing an already-cleared interval is a no-op, so the path where the old socket already closed is unaffected. With the leak fixed, test suites that exercise device handoff exit on their own, so their results can be relied on without force-exiting Jest. Changelog: [General][Fixed] - Fix the inspector proxy leaking a pages polling timer, and sending duplicate `getPages` requests, each time a device reconnects with the same device ID Differential Revision: D123883324
meta-cla
Bot
added
the
CLA Signed
|
@vzaidman has exported this pull request. If you are a Meta employee, you can view the originating Diff in D123883324. |
|
This pull request has been merged in 268b302. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Device#dangerouslyRecreateDeviceoverwrote#pagesPollingIntervalIdwithout clearing the previous interval. The old device socket'sclosehandler could not clear it either, because itssocket === #deviceSocketguard fails once reconstruct points#deviceSocketat the new socket. Every device ID collision therefore leaked a ref'd 1sgetPagespolling timer: the new device received duplicate polls, and the event loop was kept alive (Jest suites covering device handoff never exited on their own).Clear the previous polling interval before reconstructing. Clearing an already-cleared interval is a no-op, so the path where the old socket already closed is unaffected.
With the leak fixed, test suites that exercise device handoff exit on their own, so their results can be relied on without force-exiting Jest.
Changelog:
[General][Fixed] - Fix the inspector proxy leaking a pages polling timer, and sending duplicate
getPagesrequests, each time a device reconnects with the same device IDDifferential Revision: D123883324