Adopt central package management and update references (#453)

* Adopt central package management and update references

Introduces Directory.Packages.props for central NuGet package version management. Removes explicit version numbers from project files and Directory.build.props, updating them to use centrally managed versions. Cleans up test project references and deletes obsolete API approval test files. Updates solution file to include the new props file and reflect Visual Studio 18.

* Update NUnit packages and fix nullable property casing

Upgraded NUnit3TestAdapter to 5.2.0 and added NUnit.Analyzers 4.10.0 in package and build props. Also corrected the casing of the Nullable property in Fusillade.csproj to 'Enable' for consistency.

* Enable preview C# features and nullable in projects

Set <LangVersion> to 'preview' and <Nullable> to 'enable' in both Fusillade and Fusillade.Tests project files to allow use of upcoming C# features and enforce nullable reference types.

* Update Directory.build.props

* Update test dependencies and project metadata

Added and updated several test-related package references, including ReactiveUI, System.Reactive, and NUnit packages. Updated project metadata to reference ReactiveUI and Contributors, and added repository and release notes URLs.

* Update package versions and add test SDK reference

Bumped Splat to 17.1.1 and Akavache.SystemTextJson to 11.4.1 in central package management. Added Microsoft.NET.Test.Sdk as a direct dependency in Fusillade.Tests.csproj to ensure test discovery and execution.

Author: ChrisPulman

src/Directory.Packages.props

@@ -0,0 +1,28 @@
+<?xml version="1.0" encoding="utf-8"?>
+<Project>
+  <PropertyGroup>
+    <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
+  </PropertyGroup>
+  <ItemGroup>
+    <!-- Central package versions -->
+    <PackageVersion Include="punchclock" Version="4.0.2" />
+    <PackageVersion Include="Splat" Version="17.1.1" />
+    <PackageVersion Include="Akavache.SystemTextJson" Version="11.4.1" />
+    <PackageVersion Include="ReactiveUI.Testing" Version="22.2.1" />
+    <PackageVersion Include="ReactiveUI" Version="22.2.1" />
+    <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.14.1" />
+    <PackageVersion Include="NUnit" Version="4.4.0" />
+	<PackageVersion Include="NUnit3TestAdapter" Version="5.2.0" />
+	<PackageVersion Include="NUnit.Analyzers" Version="4.11.2" />
+    <PackageVersion Include="Verify.NUnit" Version="30.10.0" />
+    <PackageVersion Include="FluentAssertions" Version="8.8.0" />
+    <PackageVersion Include="PublicApiGenerator" Version="11.4.6" />
+    <PackageVersion Include="coverlet.msbuild" Version="6.0.4" />
+    <PackageVersion Include="Microsoft.SourceLink.GitHub" Version="8.0.0" />
+    <PackageVersion Include="Nerdbank.GitVersioning" Version="3.8.118" />
+    <PackageVersion Include="stylecop.analyzers" Version="1.2.0-beta.556" />
+    <PackageVersion Include="Roslynator.Analyzers" Version="4.14.0" />
+    <PackageVersion Include="Microsoft.Reactive.Testing" Version="6.1.0" />
+    <PackageVersion Include="System.Reactive" Version="6.1.0" />
+  </ItemGroup>
+</Project>

src/Directory.build.props

@@ -1,55 +1,43 @@
 <?xml version="1.0" encoding="utf-8"?>
 <Project>
 	<PropertyGroup>
+		<Copyright>Copyright (c) ReactiveUI and Contributors</Copyright>
+		<Authors>ReactiveUI and Contributors</Authors>
+		<PackageProjectUrl>https://github.com/reactiveui/fusillade/</PackageProjectUrl>
+		<PackageReleaseNotes>https://github.com/reactiveui/fusillade/releases</PackageReleaseNotes>
+		<RepositoryUrl>https://github.com/reactiveui/fusillade</RepositoryUrl>
+		
 		<NoWarn>$(NoWarn);VSX1000</NoWarn>
 		<Platform>AnyCPU</Platform>
 		<IsTestProject>$(MSBuildProjectName.Contains('Tests'))</IsTestProject>
 		<RepositoryType>git</RepositoryType>
 		<GenerateDocumentationFile>true</GenerateDocumentationFile>
 		<CodeAnalysisRuleSet>$(MSBuildThisFileDirectory)analyzers.ruleset</CodeAnalysisRuleSet>
 		<DebugType>Embedded</DebugType>
-		<Authors>.NET Foundation and Contributors</Authors>
-		<Copyright>Copyright (c) .NET Foundation and Contributors</Copyright>
 		<PackageIcon>main.png</PackageIcon>
 		<PackageReadmeFile>README.md</PackageReadmeFile>
 		<PackageLicenseExpression>MIT</PackageLicenseExpression>
-		<!-- Optional: Publish the repository URL in the built .nupkg (in the NuSpec <Repository> element) -->
 		<PublishRepositoryUrl>true</PublishRepositoryUrl>
-		<!-- Optional: Embed source files that are not tracked by the source control manager in the PDB -->
 		<EmbedUntrackedSources>true</EmbedUntrackedSources>
-		<!-- Optional: Include PDB in the built .nupkg -->
 		<AllowedOutputExtensionsInPackageBuildOutputFolder>$(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb</AllowedOutputExtensionsInPackageBuildOutputFolder>
-		<!-- disable sourcelink on mono, to workaround https://github.com/dotnet/sourcelink/issues/155 -->
 		<EnableNETAnalyzers>True</EnableNETAnalyzers>
 		<AnalysisLevel>latest</AnalysisLevel>
-		<LangVersion>preview</LangVersion>
 	</PropertyGroup>
 
 	<ItemGroup Condition="'$(IsTestProject)' != 'true'">
-		<PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="All" />
+		<PackageReference Include="Microsoft.SourceLink.GitHub" PrivateAssets="All" />
 	</ItemGroup>
 
-	<ItemGroup Condition="'$(IsTestProject)' == 'true'">
-		<PackageReference Include="ReactiveUI.Testing" Version="21.*" />
-		<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.14.1" />
-		<PackageReference Include="NUnit" Version="4.4.0" />
-		<PackageReference Include="NUnit3TestAdapter" Version="4.5.0" />
-		<PackageReference Include="Verify.NUnit" Version="30.10.0" />
-		<PackageReference Include="FluentAssertions" Version="8.8.0" />
-		<PackageReference Include="PublicApiGenerator" Version="11.4.6" />
-		<PackageReference Include="coverlet.msbuild" Version="6.0.4" PrivateAssets="All" />
-    </ItemGroup>
-
 	<ItemGroup>
-		<None Include="$(MSBuildThisFileDirectory)..\images\main.png" Pack="true" PackagePath="\"/>
-		<None Include="$(MSBuildThisFileDirectory)..\LICENSE" Pack="true" PackagePath="LICENSE" />
-		<None Include="$(MSBuildThisFileDirectory)..\README.md" Pack="true" PackagePath="\" />
+		<None Include="$(MSBuildThisFileDirectory)../images/main.png" Pack="true" PackagePath="/"/>
+		<None Include="$(MSBuildThisFileDirectory)../LICENSE" Pack="true" PackagePath="LICENSE" />
+		<None Include="$(MSBuildThisFileDirectory)../README.md" Pack="true" PackagePath="/" />
 	</ItemGroup>
 
 	<ItemGroup>
-		<PackageReference Include="Nerdbank.GitVersioning" Version="3.8.118" PrivateAssets="all" />
-		<PackageReference Include="stylecop.analyzers" Version="1.2.0-beta.556" PrivateAssets="all" />
-		<PackageReference Include="Roslynator.Analyzers" Version="4.14.0" PrivateAssets="All" />
+		<PackageReference Include="Nerdbank.GitVersioning" PrivateAssets="all" />
+		<PackageReference Include="stylecop.analyzers" PrivateAssets="all" />
+		<PackageReference Include="Roslynator.Analyzers" PrivateAssets="All" />
 	</ItemGroup>
 
 	<ItemGroup>

src/Fusillade.Tests/API/ApiApprovalTests.FusilladeTests.DotNet6_0.verified.txt

@@ -4,13 +4,27 @@
 		<NoWarn>$(NoWarn);1591;CA1707;SA1633</NoWarn>
 		<IsPackable>false</IsPackable>
 		<NoWarn>$(NoWarn);CA2000;CA1031;CA1307;CA1305</NoWarn>
+		<LangVersion>preview</LangVersion>
+		<Nullable>enable</Nullable>
 	</PropertyGroup>
 
 	<ItemGroup>
-		<ProjectReference Include="..\Fusillade\Fusillade.csproj" />
+		<ProjectReference Include="../Fusillade/Fusillade.csproj" />
 	</ItemGroup>
 
 	<ItemGroup>
-		<PackageReference Include="Akavache.SystemTextJson" Version="11.1.1" />		
+		<PackageReference Include="Akavache.SystemTextJson" />
+		<PackageReference Include="System.Reactive" />
+		<PackageReference Include="Microsoft.Reactive.Testing" />
+		<PackageReference Include="ReactiveUI" />
+		<PackageReference Include="ReactiveUI.Testing" />
+		<PackageReference Include="Microsoft.NET.Test.Sdk" />
+		<PackageReference Include="NUnit" />
+		<PackageReference Include="NUnit3TestAdapter" />
+		<PackageReference Include="NUnit.Analyzers" PrivateAssets="All" />
+		<PackageReference Include="Verify.NUnit" />
+		<PackageReference Include="PublicApiGenerator" />
+		<PackageReference Include="FluentAssertions" />
+		<PackageReference Include="coverlet.msbuild" PrivateAssets="All" />
 	</ItemGroup>
 </Project>

src/Fusillade.Tests/API/ApiApprovalTests.FusilladeTests.DotNet7_0.verified.txt

@@ -1,7 +1,7 @@
 
 Microsoft Visual Studio Solution File, Format Version 12.00
-# 17
-VisualStudioVersion = 17.7.34031.279
+# Visual Studio Version 18
+VisualStudioVersion = 18.0.11205.157 d18.0
 MinimumVisualStudioVersion = 10.0.40219.1
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Fusillade", "Fusillade\Fusillade.csproj", "{26493C47-6A4A-4F2A-9F92-046AA8CD95CC}"
 EndProject
@@ -17,6 +17,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution
 		..\CONTRIBUTING.md = ..\CONTRIBUTING.md
 		Directory.build.props = Directory.build.props
 		Directory.build.targets = Directory.build.targets
+		Directory.Packages.props = Directory.Packages.props
 		..\LICENSE = ..\LICENSE
 		..\README.md = ..\README.md
 		..\.github\workflows\release.yml = ..\.github\workflows\release.yml

src/Fusillade.Tests/API/ApiApprovalTests.FusilladeTests.Net4_7.verified.txt

@@ -2,12 +2,13 @@
 	<PropertyGroup>
 		<TargetFrameworks>netstandard2.0;net8.0;net9.0</TargetFrameworks>
 		<PackageId>fusillade</PackageId>
+		<LangVersion>preview</LangVersion>
 		<Nullable>enable</Nullable>
 		<WarningsAsErrors>CS8625;CS8604;CS8600;CS8614;CS8603;CS8618;CS8619</WarningsAsErrors>
 	</PropertyGroup>
 
 	<ItemGroup>
-		<PackageReference Include="punchclock" Version="4.0.2" />
-		<PackageReference Include="Splat" Version="16.2.1" />
+		<PackageReference Include="punchclock" />
+		<PackageReference Include="Splat" />
 	</ItemGroup>
 </Project>