Fix #1565: Return 444 status code for closed and aborted requests

[benjaminRomano]

@DonutEspresso

Issues

Closes:

• Close/aborted requests should log as http 444 #1565

Changes

Sets the response status code to 444 for aborted or closed requests.

The client will never see this response. This is solely for plugins like audit-logger and metrics to record an accurate statusCode instead of what was set using res.send

[retrohacker]

This LGTM 👍

[retrohacker]

Thanks for this @benjaminRomano

IIRC we just did something similar at another layer in our stack @DonutEspresso?

[DonutEspresso]

Awesome, thank you for this PR @benjaminRomano, 💯 for including tests!

Only one minor point of feedback - I would prefer we check against the connectionStates aborted or close before setting the status code. In the event that should we introduce a new connectionState, such a check would make sure we're not setting 444 for all cases where it may not be applicable.

Aside from that, LGTM.

[benjaminRomano]

👍 I agree checking connectionState explicitly is safer. I've updated the PR

@DonutEspresso

[benjaminRomano]

@retrohacker I believe this is ready to be merged