Skip to content

Conversation

@misterdjules
Copy link
Contributor

Pre-Submission Checklist

  • Opened an issue discussing these changes before opening the PR
  • Ran the linter and tests via make prepush
  • Included comprehensive and convincing tests for changes

Issues

Closes:

Summarize the issues that discussed these changes

Changes

What does this PR do?

Fix more occurrences of the problem described at #1691. Previous fixes did not cover the whole tests suite. I expect all it to be fully covered now.

@misterdjules misterdjules requested a review from a team December 22, 2018 00:05
@misterdjules
Copy link
Contributor Author

Tests failure is not a regression due to this PR and is fixed by #1729, thus merging this asap. Thanks for the review @DonutEspresso!

@misterdjules misterdjules merged commit 71aac42 into master Dec 22, 2018
@misterdjules
Copy link
Contributor Author

Ah, that commit message should probably have used the test: prefix, not fix:. It shouldn't have any impact though, since I assume the next release will be at least a patch release and thus would bump the patch version number anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants