Skip to content

feat: add router.render() back to support hypermedia usecase #1752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rajatkumar merged 2 commits into from
Mar 4, 2019
Merged

feat: add router.render() back to support hypermedia usecase #1752

rajatkumar merged 2 commits into from
Mar 4, 2019

Conversation

@rajatkumar
Copy link
Contributor

@rajatkumar rajatkumar commented Feb 22, 2019

Pre-Submission Checklist

  • Opened an issue discussing these changes before opening the PR
  • Ran the linter and tests via make prepush
  • Included comprehensive and convincing tests for changes

Issues

Closes:

Summarize the issues that discussed these changes

Changes

  • Adds render() to router.js
  • Adds unit tests

What does this PR do?
This PR fixes #1684 and brings back the router.render(). Most of the work was done in PR #1702 just added some documentation and cleaned up tests a little bit.

@rajatkumar rajatkumar merged commit 0700cfd into master Mar 4, 2019
@ghermeto ghermeto mentioned this pull request Jul 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DonutEspresso DonutEspresso DonutEspresso approved these changes

@misterdjules misterdjules Awaiting requested review from misterdjules

+1 more reviewer

@hekike hekike hekike approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Router.render() disappeared in 7, where did it go?

4 participants

@rajatkumar @hekike @DonutEspresso