Add tests and fix behavior of remove prefix #276
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tofandel
force-pushed
the
private-to-public
branch
from
d13a1c1 to
8775fc9
Compare
Tofandel
force-pushed
the
private-to-public
branch
from
bfa769d to
da33de1
Compare
Tofandel
force-pushed
the
private-to-public
branch
from
da33de1 to
e0acafd
Compare
Contributor
|
It looks like this has some merge conflicts. |
jathak
added a commit
that referenced
this pull request
Jun 30, 2025
commit e0acafd Author: Tofandel <[email protected]> Date: Wed Apr 9 14:02:44 2025 +0200 Simplify unprefix cognitive complexity commit 601ee43 Author: Tofandel <[email protected]> Date: Wed Apr 9 12:19:02 2025 +0200 No need to run privateToPublic twice commit 8775fc9 Author: Tofandel <[email protected]> Date: Wed Apr 9 10:48:32 2025 +0200 Add tests and fix behavior of remove prefix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few more fixes over #275
Mainly runs unprefixing before unprivatizing a variable to handle cases where the prefix could have leading dashes or underscores