-
Notifications
You must be signed in to change notification settings - Fork 0
Description
This brings up a separate issue, which I will file a separate bug for if you want: with
update, any changes in the subprojects are silently discarded! I kept changing the subprojects, and if I didn't check my changes in yet, when I built the parent, the changes were overwritten. It might be good to warn the user and stop the build ifupdateis enabled, and there are local changes to subprojects that are not yet committed.
Originally posted by @lukehutch in #40
Yeah, that's how
git submoduleworks: if you don't stage your changed submodule (i.e.git add path/to/submodule), it will be reverted to the revision it's currently pointing to when you rungit submodule update. In spite of this, I do agree that throwing away a user's changes might lead to confusion or frustration. I'm thinking of adding afailOnUnstagedChangesflag that would default totrue, but that can be turned off by the user (in which case it would only produce warnings). I'll file this as a separate feature request and keep this discussion centered on your original inquiry.