Commit 20cadc8
docs(data-drains): describe the resolved feature, not the bare flag (#7475)
* docs(data-drains): describe the resolved feature, not the bare flag
Two things were wrong in the self-hosted flag paragraph.
The first sentence attributed the page and the endpoints to
`DATA_DRAINS_ENABLED` alone, which the next sentence then contradicted.
`enterpriseFeatureEnabled` resolves `explicit ?? (ENTERPRISE_ENABLED || legacy
default)`, and the legacy default for data drains is `false` — so the feature is
on with the variable unset whenever `ENTERPRISE_ENABLED` is set, and an explicit
`false` always wins. The paragraph now leads with that resolution.
The rationale given for the public twin was also wrong. Inside a workspace
`WorkspaceHostProvider` seeds the deployment shape from the server-resolved host
context, `useDeploymentShape()` returns that seeded value, and the settings
sidebar gates `data-drains` on `features.dataDrains` from it — so the page
follows the server regardless of the twin, and "set it so the browser matches
the server" misdescribed what the browser reads. The twin still backs
`browserFallbackShape()` where nothing has seeded the shape, and it is what
`sim-setup doctor` compares, so the advice to set it stands with the real reason.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
* docs(data-drains): say the master switch must be true, not merely set
`isEnterpriseEnabled` is `isTruthy(env.ENTERPRISE_ENABLED)`, so
`ENTERPRISE_ENABLED=false` is set and still resolves off. "Is set" would have
implied an unset `DATA_DRAINS_ENABLED` turns drains on there.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>1 parent 33b6773 commit 20cadc8
1 file changed
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
237 | 237 | | |
238 | 238 | | |
239 | 239 | | |
240 | | - | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
241 | 243 | | |
242 | 244 | | |
243 | 245 | | |
| |||
0 commit comments