Commit 319724f
committed
test(bigquery): assert the body project id unconditionally
Eighth instance of the vacuous-assertion pattern, found by auditing my own
if-guarded expects.
The body check was wrapped in if (serialized?.includes('projectId')), so it
stopped verifying the moment a body dropped the field — the assertion guarded
itself out of existence. All three tools carry projectId in defaultDataset,
tableReference or datasetReference, so requiring it is correct.
Verified: removing projectId from query.ts's body now fails two assertions
where it previously passed silently.1 parent 41c6b02 commit 319724f
1 file changed
Lines changed: 11 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
159 | 159 | | |
160 | 160 | | |
161 | 161 | | |
162 | | - | |
163 | | - | |
164 | | - | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
165 | 172 | | |
166 | 173 | | |
167 | 174 | | |
| |||
181 | 188 | | |
182 | 189 | | |
183 | 190 | | |
184 | | - | |
185 | | - | |
186 | | - | |
| 191 | + | |
187 | 192 | | |
188 | 193 | | |
189 | 194 | | |
| |||
0 commit comments