Skip to content

Commit 375a74a

Browse files
waleedlatif1claude
andcommitted
fix: address the first review round
- The Access picker offered Slack options that member provisioning would then reject: it filtered on `status` but not `configurationStatus`. Rendering the field for Slack is what exposed this, so it belongs with that change. Now mirrors provisioning, which skips anything not `ready`. - "The bundled Redis runs without persistence" was only true of the chart. The Compose stack leaves Redis on its default snapshotting with no mounted volume, so webhook markers survive a restart there but not recreating the container. - Redis is not optional at one replica: CLI authentication's approval store has no fallback and throws without it. The values guidance implied the requirement began above one replica. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015BwsJTEQRzWJaY4BRCkPZt
1 parent 38b1277 commit 375a74a

4 files changed

Lines changed: 7 additions & 4 deletions

File tree

apps/docs/content/docs/platform/self-hosting/redis.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ Sim uses Redis as a message bus and shared cache. Both deployments ship it by de
2626

2727
Everything Sim keeps in Redis is cache, coordination state, or an in-flight event — never committed data, which lives in PostgreSQL and object storage. Losing or restarting the instance costs active runs their streaming, and a cancellation issued across the gap may not land.
2828

29-
It also costs webhook deduplication. Webhook idempotency markers live wherever the cache does, with a 7-day TTL sized to the longest provider retry window, so a redelivery arriving after a restart can re-run a workflow that already completed — with its real side effects. Billing, checkout, and Chat-send idempotency are pinned to PostgreSQL and are never at risk. The bundled Redis runs without persistence, which is fine for coordination state; if duplicate webhook side effects would be unacceptable for your deployment, point `REDIS_URL` at a managed instance with persistence enabled.
29+
It also costs webhook deduplication. Webhook idempotency markers live wherever the cache does, with a 7-day TTL sized to the longest provider retry window, so a redelivery arriving after a restart can re-run a workflow that already completed — with its real side effects. Billing, checkout, and Chat-send idempotency are pinned to PostgreSQL and are never at risk. The chart's bundled Redis runs with persistence off entirely, so any restart drops the markers. The Compose stack leaves Redis on its default snapshotting with no mounted volume, so they survive a restart but not recreating the container. If duplicate webhook side effects would be unacceptable for your deployment, point `REDIS_URL` at a managed instance with persistence enabled.
3030

3131
## Configuration
3232

apps/sim/app/workspace/[workspaceId]/knowledge/[id]/hooks/use-connector-member-group-options.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,8 @@ export function useConnectorMemberGroupOptions({
9999
for (const group of settings.credentialGroups) {
100100
if (group.status !== 'active') continue
101101
for (const option of group.options) {
102-
if (option.status !== 'active') continue
102+
/** Mirrors member provisioning, which skips anything not `ready`. */
103+
if (option.status !== 'active' || option.configurationStatus !== 'ready') continue
103104
if (!isCredentialGroupProvider(option.provider)) continue
104105
if (getCredentialGroupProviderId(option.provider) !== providerId) continue
105106
entries.push({

helm/sim/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ apiVersion: v2
22
name: sim
33
description: A Helm chart for Sim - the open-source AI workspace where teams build, deploy, and manage AI agents
44
type: application
5-
version: 1.9.1
5+
version: 1.9.2
66
appVersion: "v0.8.18"
77
kubeVersion: ">=1.25.0-0"
88
home: https://sim.ai

helm/sim/values.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -585,7 +585,9 @@ realtime:
585585
# Redis — pub/sub, the Socket.IO adapter, and the idempotency/progress stores.
586586
# Bundled by default so a chart install matches the Docker Compose stack.
587587
# REQUIRED once app.replicaCount or realtime.replicaCount exceeds 1: without it
588-
# cross-pod events are silently dropped. For production prefer a managed
588+
# cross-pod events are silently dropped. CLI authentication requires it at any
589+
# replica count — its approval store has no fallback and throws without Redis.
590+
# For production prefer a managed
589591
# instance (ElastiCache, Memorystore, Azure Cache) — set enabled: false and put
590592
# its connection string in app.env.REDIS_URL, which then takes over.
591593
redis:

0 commit comments

Comments
 (0)