Commit 5e71e57
committed
test: drop assertions that cannot fail
Four tests asserted nothing about the code under test:
- app/api/copilot/methods/route.test.ts was the directory's only file — it
asserted expect(true).toBe(true) against a route that does not exist.
- tools/index.test.ts carried a block self-documented as existing "to
maintain test count".
- mcp/storage/memory-cache.test.ts closed a delete-a-missing-key case with
expect(true).toBe(true); it now asserts the call resolves without throwing.
- realtime/src/index.test.ts checked typeof roomManager.x === 'function' and
typeof process.on === 'function', both of which tsc already proves.
Removing the realtime cases leaves a real gap: index.ts registers
uncaughtException, unhandledRejection, SIGINT and SIGTERM handlers with no
coverage. Better to have that gap visible than papered over by a test that
would pass with the handlers deleted.1 parent f4692ec commit 5e71e57
4 files changed
Lines changed: 1 addition & 32 deletions
File tree
- apps
- realtime/src
- sim
- app/api/copilot/methods
- lib/mcp/storage
- tools
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
320 | 320 | | |
321 | 321 | | |
322 | 322 | | |
323 | | - | |
324 | | - | |
325 | | - | |
326 | | - | |
327 | | - | |
328 | | - | |
329 | | - | |
330 | | - | |
331 | | - | |
332 | | - | |
333 | | - | |
334 | 323 | | |
335 | 324 | | |
336 | 325 | | |
337 | | - | |
338 | | - | |
339 | | - | |
340 | | - | |
341 | 326 | | |
342 | 327 | | |
343 | 328 | | |
| |||
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
142 | 142 | | |
143 | 143 | | |
144 | 144 | | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
| 145 | + | |
149 | 146 | | |
150 | 147 | | |
151 | 148 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3623 | 3623 | | |
3624 | 3624 | | |
3625 | 3625 | | |
3626 | | - | |
3627 | | - | |
3628 | | - | |
3629 | | - | |
3630 | | - | |
3631 | | - | |
3632 | 3626 | | |
3633 | 3627 | | |
3634 | 3628 | | |
| |||
0 commit comments