refactor(sso): keep provider deletion in details

Author: waleedlatif1

apps/sim/ee/sso/components/sso-provider-list.tsx

@@ -1,7 +1,6 @@
 'use client'
 
 import type { SsoProviderView } from '@/lib/api/contracts/auth'
-import { RowActionsMenu } from '@/app/workspace/[workspaceId]/settings/components/row-actions-menu'
 import { SettingsPanel } from '@/app/workspace/[workspaceId]/settings/components/settings-panel'
 import {
   RESOURCE_LIST_STACK,
@@ -15,21 +14,19 @@ interface SsoProviderListProps {
   docsLink: string
   onAdd: () => void
   onOpen: (providerId: string) => void
-  onDelete: (providerId: string) => void
 }
 
 /**
  * The organization's identity providers.
  *
  * One provider serves each verified domain, so the rows read as a routing table:
- * which domain signs in where. The caller owns deletion and its confirmation.
+ * which domain signs in where.
  */
 export function SsoProviderList({
   providers,
   active,
   onAdd,
   onOpen,
-  onDelete,
   docsLink,
 }: SsoProviderListProps) {
   return (
@@ -53,14 +50,6 @@ export function SsoProviderList({
                 onClick={() => onOpen(providerId)}
                 clickLabel={`Open ${providerId}`}
                 navigable
-                trailing={
-                  <RowActionsMenu
-                    label={`${providerId} actions`}
-                    actions={[
-                      { label: 'Delete', onSelect: () => onDelete(providerId), destructive: true },
-                    ]}
-                  />
-                }
               />
             )
           })}

apps/sim/ee/sso/components/sso-settings.test.tsx

@@ -224,19 +224,17 @@ vi.mock('@/ee/sso/hooks/sso', () => ({
   useSSOProviders: mockUseSSOProviders,
 }))
 
-/** The resource row is design-system chrome; here it is a labelled button carrying its text and trailing menu. */
+/** The resource row is design-system chrome; here it is a labelled button carrying its text. */
 vi.mock('@/app/workspace/[workspaceId]/settings/components/settings-resource-row', () => ({
   RESOURCE_LIST_STACK: '',
   SettingsResourceRow: ({
     title,
     description,
-    trailing,
     clickLabel,
     onClick,
   }: {
     title: ReactNode
     description?: ReactNode
-    trailing?: ReactNode
     clickLabel?: string
     onClick?: () => void
   }) => (
@@ -245,24 +243,10 @@ vi.mock('@/app/workspace/[workspaceId]/settings/components/settings-resource-row
         {title}
         {description}
       </button>
-      {trailing}
     </div>
   ),
 }))
 
-/** The row menu is a dropdown; here each action is a plain button so the delete path is reachable. */
-vi.mock('@/app/workspace/[workspaceId]/settings/components/row-actions-menu', () => ({
-  RowActionsMenu: ({ actions }: { actions: Array<{ label: string; onSelect: () => void }> }) => (
-    <span>
-      {actions.map((action) => (
-        <button key={action.label} type='button' onClick={action.onSelect}>
-          {action.label}
-        </button>
-      ))}
-    </span>
-  ),
-}))
-
 vi.mock('@/hooks/queries/organization', () => ({
   useOrganizationBilling: mockUseOrganizationBilling,
 }))
@@ -765,11 +749,12 @@ describe('SSO provider list', () => {
     expect(findButton('Identity providers')).toBeUndefined()
   })
 
-  it('deletes a provider after confirmation', async () => {
+  it('deletes a provider from its details after confirmation', async () => {
     const mutateAsync = vi.fn().mockResolvedValue({ success: true })
     mockUseDeleteSSOProvider.mockReturnValue({ isPending: false, mutateAsync })
     renderSso('org-a')
 
+    openProvider('provider-a')
     act(() => findButton('Delete')?.click())
     expect(container.querySelector('[role="dialog"]')).toHaveTextContent('Delete identity provider')
 
@@ -781,7 +766,7 @@ describe('SSO provider list', () => {
     expect(mutateAsync).toHaveBeenCalledWith('provider-a')
   })
 
-  it('offers delete on the provider detail as well', () => {
+  it('offers delete on the provider detail', () => {
     renderSso('org-a')
     openProvider('provider-a')
 

apps/sim/ee/sso/components/sso-settings.tsx

@@ -125,7 +125,6 @@ function OrganizationSsoSettings({ organizationId }: SSOProps) {
             docsLink={DOCS_LINKS['sign-in']}
             onAdd={() => void setParams({ provider: null, createProvider: true })}
             onOpen={(providerId) => void setParams({ provider: providerId, createProvider: null })}
-            onDelete={setPendingDeleteId}
           />
         ) : (
           <SsoProviderSettings