fix(oracle-epm-platform): address contract and review findings

Author: Bill Leoutsakos

apps/docs/content/docs/integrations/oracle_epm_platform.mdx

@@ -690,7 +690,7 @@ export const OracleEpmPlatformBlock: BlockConfig<
       required: true,
     },
     {
-      value: () => false,
+      defaultValue: false,
       id: 'skipNext',
       title: 'Skip Next Scheduled Maintenance',
       type: 'switch',
@@ -701,7 +701,7 @@ export const OracleEpmPlatformBlock: BlockConfig<
       mode: 'advanced',
     },
     {
-      value: () => false,
+      defaultValue: false,
       id: 'enabled',
       title: 'Enable Setting',
       type: 'switch',
@@ -743,7 +743,7 @@ export const OracleEpmPlatformBlock: BlockConfig<
         field: 'operation',
         value: ['oracle_epm_platform_create_groups', 'oracle_epm_platform_delete_groups'],
       },
-      placeholder: '[{"groupname":"Finance","description":"Finance team"}]',
+      placeholder: '[{"groupname":"Finance"}]',
       required: true,
       rows: 4,
     },
@@ -882,7 +882,7 @@ export const OracleEpmPlatformBlock: BlockConfig<
       mode: 'advanced',
     },
     {
-      value: () => false,
+      defaultValue: false,
       id: 'importUsers',
       title: 'Import Identity-domain Users and Roles',
       type: 'switch',
@@ -908,7 +908,7 @@ export const OracleEpmPlatformBlock: BlockConfig<
       },
     },
     {
-      value: () => true,
+      defaultValue: true,
       id: 'resetPassword',
       title: 'Require Password Reset at First Login',
       type: 'switch',
@@ -930,7 +930,7 @@ export const OracleEpmPlatformBlock: BlockConfig<
         field: 'operation',
         value: ['oracle_epm_platform_get_admin_job_status'],
       },
-      placeholder: 'Numeric ID returned by a starter',
+      placeholder: 'Exact jobId returned by a starter',
       required: true,
     },
     {
@@ -959,7 +959,7 @@ export const OracleEpmPlatformBlock: BlockConfig<
       ],
     },
     {
-      value: () => false,
+      defaultValue: false,
       id: 'waitForCompletion',
       title: 'Wait for Completion',
       type: 'switch',
@@ -1093,7 +1093,7 @@ export const OracleEpmPlatformBlock: BlockConfig<
     startTime: {
       type: 'string',
       description:
-        'Whole-hour start time: HH:00, optionally followed by a space and a time zone such as 19:00 America/Los_Angeles',
+        'Start time from 00:00 through 23:59 (HH:MM), optionally followed by a space and a standard time zone such as 14:35 America/Los_Angeles',
     },
     skipNext: {
       type: 'boolean',
@@ -1189,7 +1189,8 @@ export const OracleEpmPlatformBlock: BlockConfig<
     },
     jobId: {
       type: 'string',
-      description: 'Numeric job ID returned by an administrative starter',
+      description:
+        'Exact jobId returned by a starter: an Oracle numeric ID or a tagged Sim repository-upload reference',
     },
     jobKind: {
       type: 'string',
@@ -1531,7 +1532,7 @@ export const OracleEpmPlatformBlock: BlockConfig<
 }
 
 export const OracleEpmPlatformBlockMeta = {
-  tags: ['security', 'automation', 'monitoring'],
+  tags: ['identity', 'automation', 'monitoring'],
   url: 'https://www.oracle.com/performance-management/',
   templates: [
     {

apps/sim/blocks/blocks/oracle_epm_platform.ts

@@ -121,8 +121,17 @@ describe('Oracle EPM Platform in-process execution', () => {
     },
     { operation: 'get_admin_job_status', input: { jobKind: 'planning', jobId: '12' } },
     { operation: 'delete_file', input: { fileName: '../other' } },
+    { operation: 'delete_file', input: { fileName: 'inbox\\..\\other' } },
+    { operation: 'delete_file', input: { fileName: 'inbox\\\\other' } },
+    { operation: 'delete_file', input: { fileName: 'C:\\other' } },
+    { operation: 'delete_file', input: { fileName: 'inbox/\uD800.csv' } },
+    { operation: 'get_snapshot', input: { snapshotName: '\uDC00' } },
+    { operation: 'set_maintenance_window', input: { startTime: '24:00' } },
+    { operation: 'set_maintenance_window', input: { startTime: '23:60' } },
+    { operation: 'set_maintenance_window', input: { startTime: '14:35 Bad\\Zone' } },
     { operation: 'create_users', input: { users: [{ userlogin: 'u', password: 'input-secret' }] } },
     { operation: 'update_users', input: { users: [{ userlogin: 'u', password: 'input-secret' }] } },
+    { operation: 'update_users', input: { users: [{ userlogin: 'u' }] } },
     {
       operation: 'import_snapshot',
       input: { snapshotName: 'Snapshot', userPassword: 'input-secret', importUsers: false },
@@ -138,6 +147,40 @@ describe('Oracle EPM Platform in-process execution', () => {
     expect(mockSecureFetch).not.toHaveBeenCalled()
   })
 
+  it.each(['00:00', '23:59', '14:35 America/Los_Angeles'])(
+    'accepts documented maintenance time %s unchanged',
+    async (startTime) => {
+      expect((await execute('set_maintenance_window', { ...auth, startTime })).status).toBe(200)
+      expect(JSON.parse(mockSecureFetch.mock.calls[0][2].body)).toEqual({ startTime })
+    }
+  )
+
+  it.each(['inbox\\file1.csv', 'inbox/report📄.csv'])(
+    'preserves the exact JSON delete filename %s, including valid Unicode pairs',
+    async (fileName) => {
+      expect((await execute('delete_file', { ...auth, fileName })).status).toBe(200)
+      expect(mockSecureFetch.mock.calls[0][0]).toBe(
+        'https://epm.example.com/gateway/interop/rest/v3/files/delete'
+      )
+      expect(JSON.parse(mockSecureFetch.mock.calls[0][2].body)).toEqual({ fileName })
+    }
+  )
+
+  it('does not report success when the caller cancels during response projection', async () => {
+    const controller = new AbortController()
+    mockSecureFetch.mockImplementation(async () => {
+      const response = Response.json({ status: 0, items: [] })
+      response.json = async () => {
+        controller.abort(new DOMException('Cancelled', 'AbortError'))
+        return { status: 0, items: [] }
+      }
+      return response
+    })
+    await expect(execute('list_files', auth, controller.signal)).rejects.toMatchObject({
+      name: 'AbortError',
+    })
+  })
+
   it('reports identity partial failure as tool failure while retaining structured item results', async () => {
     mockSecureFetch.mockImplementation(async () =>
       Response.json({

apps/sim/lib/internal/oracle-epm-platform/execute-tool.test.ts

@@ -2,7 +2,7 @@ import { ORACLE_EPM_SERVICE_ACCOUNT_PROVIDER_ID } from '@/lib/credentials/client
 import { createOracleEpmClient } from '@/lib/internal/oracle-epm/client.server'
 import { OracleEpmError } from '@/lib/internal/oracle-epm/errors'
 import { OracleEpmPlatformFileError } from '@/lib/internal/oracle-epm-platform/files.server'
-import { oracleEpmPlatformOperations } from '@/lib/internal/oracle-epm-platform/operations'
+import { oracleEpmPlatformToolHandlers } from '@/lib/internal/oracle-epm-platform/operations'
 import {
   OracleEpmPlatformResponseError,
   OracleEpmPlatformStatusError,
@@ -56,11 +56,12 @@ async function executeOperation<K extends OracleEpmPlatformOperation>(
     accessToken: input.accessToken,
     instanceUrl: input.instanceUrl,
   })
-  const output = await oracleEpmPlatformOperations[operation](input, {
+  const output = await oracleEpmPlatformToolHandlers[operation](input, {
     client,
     signal: request.signal,
     execution: request.context,
   })
+  request.signal?.throwIfAborted()
   const success = output.status <= 0 && !('partialFailure' in output && output.partialFailure)
   return Response.json({
     success,

apps/sim/lib/internal/oracle-epm-platform/execute-tool.ts

@@ -259,14 +259,56 @@ describe('Oracle EPM source files and chunked uploads', () => {
     })
   })
 
-  it('rejects repository size mismatch before sending a mutation', async () => {
-    await expect(
-      uploadRepositoryFile(
-        { ...auth, file: { ...file, size: 4 }, fileName: 'data.csv' },
+  it.each([2, 4])(
+    'rejects repository declared size %s mismatch before sending a mutation',
+    async (size) => {
+      await expect(
+        uploadRepositoryFile(
+          { ...auth, file: { ...file, size }, fileName: 'data.csv' },
+          fileContext
+        )
+      ).rejects.toThrow('declared file size')
+      expect(mockSecureFetch).not.toHaveBeenCalled()
+    }
+  )
+
+  it('copies repository source chunks directly into the bounded upload body', async () => {
+    storage.downloadFileStream.mockImplementation(async () =>
+      Readable.from([Buffer.from('a'), Buffer.from('bc')])
+    )
+    await uploadRepositoryFile({ ...auth, file, fileName: 'data.csv' }, fileContext)
+    expect(mockSecureFetch.mock.calls[0][2].body).toEqual(Buffer.from('abc'))
+  })
+
+  it('returns an immediate legacy extraction reference after a repository snapshot upload', async () => {
+    mockSecureFetch.mockImplementation(async () =>
+      Response.json({
+        status: -1,
+        links: [
+          {
+            rel: 'Job Status',
+            action: 'GET',
+            href: 'https://epm.example.com/gateway/interop/rest/11.1.2.3.600/applicationsnapshots/Artifact%20Snapshot.zip/contents/status',
+          },
+        ],
+      })
+    )
+    expect(
+      await uploadRepositoryFile(
+        {
+          ...auth,
+          file,
+          fileName: 'Artifact Snapshot.zip',
+        },
         fileContext
       )
-    ).rejects.toThrow('declared file size')
-    expect(mockSecureFetch).not.toHaveBeenCalled()
+    ).toMatchObject({
+      bytesUploaded: 3,
+      completed: false,
+      jobKind: 'snapshot_upload',
+      jobId: 'repository:Artifact%20Snapshot.zip',
+    })
+    expect(mockSecureFetch.mock.calls.map(([, , options]) => options.method)).toEqual(['POST'])
   })
 
   it('uses inclusive contiguous ranges, one-based chunk numbers, and empty init/finalize control bodies', async () => {
@@ -405,6 +447,26 @@ describe('Oracle EPM source files and chunked uploads', () => {
     ).toBe(true)
   })
 
+  it('rejects late cancellation after finalization without deleting the accepted snapshot', async () => {
+    const controller = new AbortController()
+    mockSecureFetch.mockImplementation(async (url: string) => {
+      const response = Response.json({ status: 0 })
+      if (JSON.parse(new URL(url).searchParams.get('q') ?? '{}').isLast) {
+        response.json = async () => {
+          controller.abort(new DOMException('Cancelled', 'AbortError'))
+          return { status: 0 }
+        }
+      }
+      return response
+    })
+    await expect(
+      uploadSnapshot(snapshotInput(), { ...fileContext, signal: controller.signal })
+    ).rejects.toMatchObject({ name: 'AbortError' })
+    expect(mockSecureFetch.mock.calls.some(([url]) => String(url).endsWith('/files/delete'))).toBe(
+      false
+    )
+  })
+
   it('cancels an interrupted source and uses a separate bounded signal for owned cleanup', async () => {
     const controller = new AbortController()
     storage.downloadFileStream.mockImplementation(async () =>
@@ -534,4 +596,25 @@ describe('Oracle EPM v2 streamed downloads', () => {
       true
     )
   })
+
+  it('removes its completed local output when cancellation overlaps remote cleanup', async () => {
+    const controller = new AbortController()
+    setDownload()
+    const provider = mockSecureFetch.getMockImplementation()!
+    mockSecureFetch.mockImplementation(async (...args) => {
+      const response = await provider(...args)
+      if (args[2].method === 'DELETE') {
+        expect(storage.complete).toHaveBeenCalled()
+        controller.abort(new DOMException('Cancelled', 'AbortError'))
+      }
+      return response
+    })
+    await expect(
+      downloadRepositoryFile(downloadInput, { ...fileContext, signal: controller.signal })
+    ).rejects.toMatchObject({ name: 'AbortError' })
+    expect(storage.deleteFile).toHaveBeenCalledWith({
+      key: 'execution/result.zip',
+      context: 'execution',
+    })
+  })
 })

apps/sim/lib/internal/oracle-epm-platform/files.server.test.ts

@@ -7,7 +7,11 @@ import {
   storeOracleEpmDownload,
 } from '@/lib/internal/oracle-epm/files.server'
 import { pollOracleEpmJob } from '@/lib/internal/oracle-epm/jobs'
-import { projectJob, readJobLink } from '@/lib/internal/oracle-epm-platform/jobs'
+import {
+  projectJob,
+  projectRepositoryUploadJob,
+  readJobLink,
+} from '@/lib/internal/oracle-epm-platform/jobs'
 import type { OracleEpmPlatformOperationContext } from '@/lib/internal/oracle-epm-platform/operations'
 import {
   filesSchema,
@@ -30,6 +34,7 @@ import {
   SNAPSHOT_FILE_LIMIT,
 } from '@/lib/internal/oracle-epm-platform/routes'
 import type { OracleEpmPlatformInput } from '@/lib/internal/oracle-epm-platform/schemas'
+import { deleteFile } from '@/lib/uploads/core/storage-service'
 import type { UserFile } from '@/executor/types'
 import type {
   OracleEpmPlatformOutputMap,
@@ -141,14 +146,17 @@ export async function uploadRepositoryFile(
   // Generic uploads are bounded to 100 MiB and use the documented single-request API.
   const bytes = Buffer.alloc(input.file.size)
   let offset = 0
-  for await (const chunk of verifiedChunks(
-    source.chunks,
-    input.file.size,
-    SNAPSHOT_CHUNK_LIMIT,
-    signal
-  )) {
+  for await (const chunk of source.chunks) {
+    signal?.throwIfAborted()
+    if (offset + chunk.byteLength > input.file.size) {
+      throw new OracleEpmPlatformFileError('Source file bytes exceed the declared file size')
+    }
     bytes.set(chunk, offset)
-    offset += chunk.length
+    offset += chunk.byteLength
+  }
+  signal?.throwIfAborted()
+  if (offset !== input.file.size) {
+    throw new OracleEpmPlatformFileError('Source file bytes do not match the declared file size')
   }
   const value = jsonBody(
     await client.request(endpoints.upload_repository_file, {
@@ -158,9 +166,10 @@ export async function uploadRepositoryFile(
       signal,
     })
   )
+  signal?.throwIfAborted()
   // The upload reference also permits asynchronous extraction of an LCM artifact.
   return {
-    ...projectJob(client, value, 'snapshot_upload'),
+    ...projectRepositoryUploadJob(client, value, input.fileName),
     fileName: input.fileName,
     bytesUploaded: offset,
   }
@@ -231,6 +240,7 @@ export async function uploadSnapshot(
     }
     finalizing = true
     const value = await send({ isFirst: false, chunkSize: 14, fileSize, isLast: true })
+    signal?.throwIfAborted()
     return {
       ...projectJob(client, value, 'snapshot_upload'),
       snapshotName: input.snapshotName,
@@ -380,6 +390,12 @@ export async function downloadRepositoryFile(
       )
     }
   }
+  if (signal?.aborted) {
+    // Storage completed before remote cleanup began; only this newly created output is ours.
+    // Match the foundation's completed-download cancellation cleanup.
+    if (file?.key) await deleteFile({ key: file.key, context: 'execution' }).catch(() => undefined)
+    signal.throwIfAborted()
+  }
   if (!file) throw new OracleEpmPlatformResponseError()
   return {
     ...statusOutput(0),