fix(tables): reconcile agent view pins

Author: j15z

apps/sim/app/workspace/[workspaceId]/tables/[tableId]/table.tsx

@@ -44,6 +44,7 @@ import { useUserPermissionsContext } from '@/app/workspace/[workspaceId]/provide
 import {
   getTableViewRevision,
   resolveTableViewConfig,
+  resolveTableViewPinTransition,
   resolveTableViewSelection,
   shouldApplyTableViewRevision,
   type TableViewRevision,
@@ -719,11 +720,16 @@ export function Table({
     if (appliedViewRevisionRef.current === undefined) return
     if (!views.some((view) => view.id === viewPin.viewId)) return
     consumeViewPin(tableId, viewPin.seq)
-    if (activeViewId === viewPin.viewId || appliedViewRevisionRef.current.id === viewPin.viewId) {
-      return
-    }
+    const transition = resolveTableViewPinTransition(
+      activeViewId,
+      appliedViewRevisionRef.current.id,
+      viewPin.viewId,
+      pendingCreatedViewIdRef.current
+    )
+    if (!transition.nextViewId) return
+    pendingCreatedViewIdRef.current = transition.pendingCreatedViewId
     preservedViewStateRef.current = null
-    setTableParams({ view: viewPin.viewId })
+    setTableParams({ view: transition.nextViewId })
   }, [embedded, viewPin, views, activeViewId, tableId, consumeViewPin, setTableParams])
 
   /**

apps/sim/app/workspace/[workspaceId]/tables/[tableId]/view-state.test.ts

@@ -7,6 +7,7 @@ import { ALL_VIEW_PARAM } from '@/app/workspace/[workspaceId]/tables/[tableId]/s
 import {
   getTableViewRevision,
   resolveTableViewConfig,
+  resolveTableViewPinTransition,
   resolveTableViewSelection,
   shouldApplyTableViewRevision,
 } from '@/app/workspace/[workspaceId]/tables/[tableId]/view-state'
@@ -79,6 +80,20 @@ describe('resolveTableViewSelection', () => {
   })
 })
 
+describe('resolveTableViewPinTransition', () => {
+  it('abandons a pending local creation when an external pin replaces its URL selection', () => {
+    expect(
+      resolveTableViewPinTransition('view-old', 'view-created', 'view-pinned', 'view-created')
+    ).toEqual({ nextViewId: 'view-pinned', pendingCreatedViewId: null })
+  })
+
+  it('keeps the pending creation when the pin is already represented locally', () => {
+    expect(
+      resolveTableViewPinTransition('view-pinned', 'view-created', 'view-pinned', 'view-created')
+    ).toEqual({ nextViewId: null, pendingCreatedViewId: 'view-created' })
+  })
+})
+
 describe('shouldApplyTableViewRevision', () => {
   const cached = {
     id: 'view-1',

apps/sim/app/workspace/[workspaceId]/tables/[tableId]/view-state.ts

@@ -49,6 +49,27 @@ export interface TableViewRevision {
   updatedAt: number | null
 }
 
+export interface TableViewPinTransition {
+  nextViewId: string | null
+  pendingCreatedViewId: string | null
+}
+
+/**
+ * Resolves an external saved-view pin without leaving a locally created view
+ * waiting for a URL selection that the pin is about to replace.
+ */
+export function resolveTableViewPinTransition(
+  activeViewId: string | null,
+  appliedViewId: string | null,
+  pinnedViewId: string,
+  pendingCreatedViewId: string | null
+): TableViewPinTransition {
+  if (activeViewId === pinnedViewId || appliedViewId === pinnedViewId) {
+    return { nextViewId: null, pendingCreatedViewId }
+  }
+  return { nextViewId: pinnedViewId, pendingCreatedViewId: null }
+}
+
 export function getTableViewRevision(
   view: Pick<TableViewWire, 'id' | 'updatedAt'> | null
 ): TableViewRevision {