fix(knowledge): treat a reclaimed lease during a member purge as superseded; tidy the chat reply sources after cleanup

Author: waleedlatif1

apps/sim/app/workspace/[workspaceId]/home/components/message-content/components/message-sources/message-sources.tsx

@@ -7,7 +7,7 @@ import type { SourceTagData } from '@/app/workspace/[workspaceId]/home/component
 
 /** The action-row button, matching the copy and vote buttons beside it with room for a count. */
 const BUTTON_CLASSES =
-  'flex h-[26px] items-center gap-1 rounded-[6px] px-1.5 text-[var(--text-icon)] text-caption transition-colors hover-hover:bg-[var(--surface-hover)] focus-visible:outline-none data-[state=open]:bg-[var(--surface-hover)]'
+  'flex h-[26px] items-center gap-1 rounded-[6px] px-1.5 text-[var(--text-icon)] text-caption transition-colors hover-hover:bg-[var(--surface-hover)] focus-visible:outline-none data-[state=open]:bg-[var(--surface-active)] data-[state=open]:hover-hover:bg-[var(--surface-active)]'
 
 interface MessageSourcesProps {
   sources: readonly SourceTagData[]
@@ -36,12 +36,7 @@ export function MessageSources({ sources }: MessageSourcesProps) {
         </Tooltip.Trigger>
         <Tooltip.Content side='top'>{label}</Tooltip.Content>
       </Tooltip.Root>
-      <PopoverContent
-        align='start'
-        side='top'
-        sideOffset={4}
-        className='w-[420px] max-w-[90vw] p-0'
-      >
+      <PopoverContent align='start' side='top' sideOffset={4} className='w-[420px] p-0'>
         <div className='flex flex-col py-1'>
           {sources.map((source) => (
             <SourceCard key={source.url} source={source} dense />

apps/sim/app/workspace/[workspaceId]/home/components/message-content/components/source-card/source-card.tsx

@@ -151,7 +151,12 @@ export function SourceCard({ source, query, onSummarize, dense = false }: Source
 
   if (dense) {
     return (
-      <div className={cn(SOURCE_ROW_CLASSES, 'items-center py-1')}>
+      <div
+        className={cn(
+          SOURCE_ROW_CLASSES,
+          'items-center py-1 focus-within:bg-[var(--surface-hover)] hover-hover:bg-[var(--surface-hover)]'
+        )}
+      >
         <span className={chipIconSlotClass}>{mark}</span>
         <a
           href={source.url}
@@ -168,7 +173,7 @@ export function SourceCard({ source, query, onSummarize, dense = false }: Source
         </a>
         <OverflowText
           label={meta.join(' · ')}
-          className='max-w-[40%] shrink-0 text-[var(--text-muted)] text-caption'
+          className='max-w-[40%] flex-shrink-0 text-[var(--text-muted)] text-caption'
         />
         <div className='flex flex-shrink-0 items-center opacity-0 transition-opacity group-focus-within/source:opacity-100 group-hover/source:opacity-100 [@media(hover:none)]:opacity-100'>
           <CopyLinkAction url={source.url} />

apps/sim/app/workspace/[workspaceId]/home/components/message-content/message-content.tsx

@@ -958,7 +958,6 @@ function MessageContentInner({
       trailingPendingTag ||
       (isStreamIdle && !trailingStreamActivity && !hasExecutingTool))
 
-  /** The action buttons and, when the reply cited documents, the sources button beside them. */
   const actionsRow = (
     <div className='flex items-center gap-0.5'>
       {actions}

apps/sim/app/workspace/[workspaceId]/home/home.tsx

@@ -198,9 +198,7 @@ export function Home({ chatId, userName, userId }: HomeProps) {
   /** The bases an Ask turn is grounded in; read through a ref so a list refresh never rebuilds the submit handler. */
   const { data: knowledgeBases = EMPTY_KNOWLEDGE_BASES } = useKnowledgeBasesQuery(workspaceId)
   const knowledgeBasesRef = useRef(knowledgeBases)
-  useEffect(() => {
-    knowledgeBasesRef.current = knowledgeBases
-  }, [knowledgeBases])
+  knowledgeBasesRef.current = knowledgeBases
   const hasCheckedLandingStorageRef = useRef(false)
   const initialViewInputRef = useRef<HTMLDivElement>(null)
   const initialViewUserInputRef = useRef<UserInputHandle>(null)
@@ -503,7 +501,6 @@ export function Home({ chatId, userName, userId }: HomeProps) {
       }
 
       prepareResourceViewForAgentTurn()
-      /** Ask is a turn of the agent grounded in the searched sources. */
       const turnContexts =
         mode === 'ask'
           ? withSearchedKnowledgeContexts(
@@ -525,14 +522,11 @@ export function Home({ chatId, userName, userId }: HomeProps) {
   const clearSearch = useCallback(() => setSearchQuery(''), [setSearchQuery])
 
   /** Summarize or Answer on a result: hand the question to the agent in Ask mode. */
-  const handleSummarize = useCallback(
-    (prompt: string) => {
-      useMothershipModeStore.getState().setMode('ask')
-      setSearchQuery('')
-      handleSubmit(prompt)
-    },
-    [handleSubmit, setSearchQuery]
-  )
+  const handleSummarize = (prompt: string) => {
+    useMothershipModeStore.getState().setMode('ask')
+    setSearchQuery('')
+    handleSubmit(prompt)
+  }
   /**
    * A chat that already exists never opens in Search: its transcript is a
    * conversation, and search results never join it. Build and Ask both carry

apps/sim/lib/knowledge/connectors/member-observations.test.ts

@@ -5,16 +5,23 @@ import { dbChainMockFns, queueTableRows, resetDbChainMock, schemaMock } from '@s
 import { beforeEach, describe, expect, it, vi } from 'vitest'
 
 vi.mock('@/lib/knowledge/documents/service', () => ({
+  ConnectorSyncDeletionGuardError: class ConnectorSyncDeletionGuardError extends Error {},
   hardDeleteDocuments: vi.fn(),
 }))
 
+import { db } from '@sim/db'
 import {
+  applyMemberDocumentLifecycle,
   rewriteConnectorAcls,
   staleMemberWindowMs,
   sweepStaleMemberObservations,
 } from '@/lib/knowledge/connectors/member-observations'
 import { MEMBER_OBSERVATION_STALE_AFTER_HOURS } from '@/lib/knowledge/connectors/sync-limits'
 import { SyncLockLostException } from '@/lib/knowledge/connectors/sync-lock'
+import {
+  ConnectorSyncDeletionGuardError,
+  hardDeleteDocuments,
+} from '@/lib/knowledge/documents/service'
 
 const NOW = new Date('2026-09-01T12:00:00Z')
 const STALE_MEMBER = { id: 'm-1', connectorId: 'c-1', syncIntervalMinutes: 60 }
@@ -120,3 +127,31 @@ describe('rewriteConnectorAcls', () => {
     expect(dbChainMockFns.update).not.toHaveBeenCalled()
   })
 })
+
+describe('applyMemberDocumentLifecycle', () => {
+  beforeEach(() => {
+    resetDbChainMock()
+    vi.mocked(hardDeleteDocuments).mockReset()
+  })
+
+  it('reports a reclaimed lease during a purge batch as the run being superseded', async () => {
+    dbChainMockFns.returning.mockResolvedValueOnce([])
+    queueTableRows(schemaMock.document, [])
+    queueTableRows(schemaMock.document, [{ id: 'd-1' }])
+    vi.mocked(hardDeleteDocuments).mockRejectedValueOnce(
+      new ConnectorSyncDeletionGuardError('lease reclaimed')
+    )
+
+    await expect(
+      applyMemberDocumentLifecycle({
+        connectorId: 'c-1',
+        knowledgeBaseId: 'kb-1',
+        runId: 'run-1',
+        withLease: (fn) => fn(db as never),
+        failedExternalIds: new Set(),
+        allowRemoval: true,
+        lease: { beatIfDue: async () => {} } as never,
+      })
+    ).rejects.toBeInstanceOf(SyncLockLostException)
+  })
+})

apps/sim/lib/knowledge/connectors/member-observations.ts

@@ -30,11 +30,13 @@ import {
   assertSyncLeaseHeldInTx,
   connectorIsLive,
   MEMBER_LOCKABLE_CONNECTOR_STATUSES,
+  SyncLockLostException,
   type SyncRunLease,
   type SyncWriteLease,
 } from '@/lib/knowledge/connectors/sync-lock'
 import {
   type ConnectorSyncDeletionGuard,
+  ConnectorSyncDeletionGuardError,
   hardDeleteDocuments,
 } from '@/lib/knowledge/documents/service'
 
@@ -364,13 +366,21 @@ export async function applyMemberDocumentLifecycle(input: {
   const purgeIds = purgeCandidates.map((row) => row.id)
   for (let offset = 0; offset < purgeIds.length; offset += PURGE_CHUNK_SIZE) {
     await input.lease.beatIfDue()
-    purged += await hardDeleteDocuments(
-      purgeIds.slice(offset, offset + PURGE_CHUNK_SIZE),
-      runId,
-      connectorId,
-      knowledgeBaseId,
-      guard
-    )
+    try {
+      purged += await hardDeleteDocuments(
+        purgeIds.slice(offset, offset + PURGE_CHUNK_SIZE),
+        runId,
+        connectorId,
+        knowledgeBaseId,
+        guard
+      )
+    } catch (error) {
+      /** The deletion guard refusing the lease is a reclaimed run, not a failed one. */
+      if (error instanceof ConnectorSyncDeletionGuardError) {
+        throw new SyncLockLostException(connectorId)
+      }
+      throw error
+    }
   }
 
   return { tombstoned: tombstoned.length, resurrected: resurrected.length, purged }