fix(search): never fail a knowledge query over a citation decision

Whether to ask for a citation is answered by a billing-backed availability
lookup, and it sat in the same `Promise.all` as the search itself — so a
rejection there discarded a search that had already succeeded and returned
"Failed to query knowledge base". A presentation choice could take out the
query it decorates.

Settle it to "do not cite" instead — the same answer the feature being off
gives — and log why, so the lookup failing is visible without being fatal.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014JmUGTitFeoQXVf9T3skEa

Author: Waleed Latif

apps/sim/lib/copilot/tools/server/knowledge/knowledge-base.test.ts

@@ -437,6 +437,18 @@ describe('manage_knowledge_base trusted application delegation', () => {
     expect(result.message).toBe('Found 0 result(s) for query "query".')
   })
 
+  it('answers without citations when the eligibility lookup fails, rather than failing the query', async () => {
+    mockIsKnowledgeMemberAccessAvailable.mockRejectedValueOnce(new Error('billing unavailable'))
+
+    const result = await knowledgeBaseServerTool.execute(
+      { operation: 'query', args: { knowledgeBaseId: KNOWLEDGE_BASE.id, query: 'query' } },
+      { ...CONTEXT, resolvedSecretTraceRegistry: new ResolvedSecretTraceRegistry() }
+    )
+
+    expect(result).toMatchObject({ success: true })
+    expect(result.message).toBe('Found 0 result(s) for query "query".')
+  })
+
   it('returns a safe model result for search infrastructure failures', async () => {
     mockSearchKnowledge.mockRejectedValueOnce(new Error('database unavailable'))
 

apps/sim/lib/copilot/tools/server/knowledge/knowledge-base.ts

@@ -451,7 +451,20 @@ export const knowledgeBaseServerTool: BaseServerTool<KnowledgeBaseArgs, Knowledg
               topK,
               resultSecretRegistry: context.resolvedSecretTraceRegistry,
             }),
-            isKnowledgeMemberAccessAvailable({ workspaceId }),
+            /**
+             * Whether to ask for a citation is a presentation choice, and it is
+             * answered by a billing-backed lookup that can reject. A rejection
+             * must not discard a search that succeeded, so it settles to "do not
+             * cite" — the same answer the feature being off gives — rather than
+             * failing the query.
+             */
+            isKnowledgeMemberAccessAvailable({ workspaceId }).catch((error) => {
+              logger.warn('Citation eligibility unavailable; answering without citations', {
+                workspaceId,
+                error: getErrorMessage(error),
+              })
+              return false
+            }),
           ])
           const results = searchResult.results
           const knowledgeBase = searchResult.knowledgeBases[0]