Skip to content

Commit b25c821

Browse files
committed
fix(resources): harden list preference checks
1 parent 5a85330 commit b25c821

4 files changed

Lines changed: 5 additions & 4 deletions

File tree

apps/sim/app/workspace/[workspaceId]/files/search-params.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ export const filesListPreferenceConfig = {
9494
sort: filesSortParams.default,
9595
filters: { type: [], size: [], uploadedBy: [] },
9696
},
97-
} satisfies ResourceListPreferenceConfig
97+
} as const satisfies ResourceListPreferenceConfig
9898

9999
/** Filter/search/sort view-state: clean URLs, no back-stack churn. */
100100
export const filesFilterUrlKeys = {

apps/sim/app/workspace/[workspaceId]/knowledge/search-params.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ export const knowledgeListPreferenceConfig = {
5252
sort: knowledgeSortParams.default,
5353
filters: { connector: [], content: [], owner: [] },
5454
},
55-
} satisfies ResourceListPreferenceConfig
55+
} as const satisfies ResourceListPreferenceConfig
5656

5757
/** Filter/search/sort view-state: clean URLs, no back-stack churn. */
5858
export const knowledgeUrlKeys = {

apps/sim/app/workspace/[workspaceId]/tables/search-params.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ export const tablesListPreferenceConfig = {
5454
sort: tablesSortParams.default,
5555
filters: { rows: [], owner: [] },
5656
},
57-
} satisfies ResourceListPreferenceConfig
57+
} as const satisfies ResourceListPreferenceConfig
5858

5959
/** Filter/search/sort view-state: clean URLs, no back-stack churn. */
6060
export const tablesUrlKeys = {

apps/sim/hooks/use-resource-list-preferences.test.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,7 @@ describe('useResourceListPreferences', () => {
292292
const applyPreference = vi.fn()
293293
const result = renderPreferenceHook({ preference: defaultPreference, applyPreference })
294294
await flushEffects()
295-
vi.spyOn(Storage.prototype, 'setItem').mockImplementation(() => {
295+
const storageWrite = vi.spyOn(localStorage, 'setItem').mockImplementation(() => {
296296
throw new DOMException('Storage is full', 'QuotaExceededError')
297297
})
298298

@@ -302,6 +302,7 @@ describe('useResourceListPreferences', () => {
302302
...defaultPreference,
303303
filters: { ...defaultPreference.filters, type: ['image'] },
304304
})
305+
storageWrite.mockRestore()
305306
})
306307

307308
it('clears filters and sort back to their complete module defaults', async () => {

0 commit comments

Comments
 (0)