test(selectors): consolidate migration regression coverage

Author: Bill Leoutsakos

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/selector-combobox/selector-combobox.test.tsx

@@ -95,31 +95,14 @@ beforeEach(() => {
 })
 
 describe('SelectorCombobox label hydration', () => {
-  it.each([
-    {
-      state: 'preview',
-      isPreview: true,
-      disabled: false,
-      previewValue: 'preview-label',
-      detailId: 'preview-label',
-    },
-    {
-      state: 'disabled',
-      isPreview: false,
-      disabled: true,
-      previewValue: undefined,
-      detailId: 'stored-label',
-    },
-  ])('keeps the list disabled but hydrates the selected value when $state', (state) => {
+  it('renders a hydrated selected label while disabled without enabling the list', () => {
     const html = renderToStaticMarkup(
       <SelectorCombobox
         blockId='block-1'
         subBlock={{ id: 'label', title: 'Label', type: 'combobox' }}
         selectorKey='jira.issues'
         selectorContext={{ workspaceId: 'workspace-1', oauthCredential: 'credential-1' }}
-        isPreview={state.isPreview}
-        disabled={state.disabled}
-        previewValue={state.previewValue}
+        disabled
       />
     )
 
@@ -130,72 +113,14 @@ describe('SelectorCombobox label hydration', () => {
     )
     expect(mockUseSelectorOptionDetail).toHaveBeenCalledWith(
       'jira.issues',
-      expect.objectContaining({ detailId: state.detailId, enabled: true })
+      expect.objectContaining({ detailId: 'stored-label', enabled: true })
     )
   })
 
-  it.each([
-    {
-      state: 'preview',
-      isPreview: true,
-      disabled: false,
-      previewValue: ['preview-label', '{{SHARED_LABEL}}', '<Block.output>'],
-      detailIds: ['preview-label', '{{SHARED_LABEL}}'],
-    },
-    {
-      state: 'disabled',
-      isPreview: false,
-      disabled: true,
-      previewValue: undefined,
-      detailIds: ['stored-one', 'stored-two'],
-    },
-  ])('hydrates selected multi-values without enabling the list when $state', (state) => {
-    if (!state.isPreview) selectorState.storeValue = ['stored-one', 'stored-two']
-
-    const html = renderToStaticMarkup(
-      <SelectorCombobox
-        blockId='block-1'
-        subBlock={{ id: 'labels', title: 'Labels', type: 'combobox' }}
-        selectorKey='jira.issues'
-        selectorContext={{ workspaceId: 'workspace-1', oauthCredential: 'credential-1' }}
-        isPreview={state.isPreview}
-        disabled={state.disabled}
-        previewValue={state.previewValue}
-        multiSelect
-      />
-    )
-
-    for (const id of state.detailIds) expect(html).toContain(`Hydrated ${id}`)
-    if (state.isPreview) expect(html).toContain('&lt;Block.output&gt;')
-    expect(mockUseSelectorOptions).toHaveBeenCalledWith(
-      'jira.issues',
-      expect.objectContaining({ enabled: false })
-    )
-    expect(mockUseSelectorOptionDetails).toHaveBeenCalledWith(
-      'jira.issues',
-      expect.objectContaining({ detailIds: state.detailIds, enabled: true })
-    )
-  })
-
-  it.each([
-    {
-      state: 'preview',
-      isPreview: true,
-      disabled: false,
-      previewValue: ['preview-label', '{{SHARED_LABEL}}', '<Block.output>'],
-      listedValues: ['preview-label'],
-    },
-    {
-      state: 'disabled',
-      isPreview: false,
-      disabled: true,
-      previewValue: undefined,
-      listedValues: ['stored-one', 'stored-two'],
-    },
-  ])('uses a search-free list to hydrate no-detail multi-values when $state', (state) => {
-    if (!state.isPreview) selectorState.storeValue = ['stored-one', 'stored-two']
+  it('renders preview labels from a search-free list when detail lookup is unsupported', () => {
+    const previewValue = ['preview-label', '{{SHARED_LABEL}}', '<Block.output>']
     mockUseSelectorOptions.mockReturnValue({
-      data: state.listedValues.map((id) => ({ id, label: `Listed ${id}` })),
+      data: [{ id: 'preview-label', label: 'Listed preview-label' }],
       isLoading: false,
       hasMore: false,
       error: null,
@@ -207,18 +132,15 @@ describe('SelectorCombobox label hydration', () => {
         subBlock={{ id: 'labels', title: 'Labels', type: 'combobox' }}
         selectorKey='gmail.labels'
         selectorContext={{ workspaceId: 'workspace-1', oauthCredential: 'credential-1' }}
-        isPreview={state.isPreview}
-        disabled={state.disabled}
-        previewValue={state.previewValue}
+        isPreview
+        previewValue={previewValue}
         multiSelect
       />
     )
 
-    for (const id of state.listedValues) expect(html).toContain(`Listed ${id}`)
-    if (state.isPreview) {
-      expect(html).toContain('{{SHARED_LABEL}}')
-      expect(html).toContain('&lt;Block.output&gt;')
-    }
+    expect(html).toContain('Listed preview-label')
+    expect(html).toContain('{{SHARED_LABEL}}')
+    expect(html).toContain('&lt;Block.output&gt;')
     expect(mockUseSelectorOptions).toHaveBeenCalledWith(
       'gmail.labels',
       expect.objectContaining({ enabled: true, search: undefined })
@@ -228,24 +150,4 @@ describe('SelectorCombobox label hydration', () => {
       expect.objectContaining({ enabled: false })
     )
   })
-
-  it('does not detail-hydrate a runtime reference', () => {
-    selectorState.storeValue = '<Block.output>'
-
-    const html = renderToStaticMarkup(
-      <SelectorCombobox
-        blockId='block-1'
-        subBlock={{ id: 'label', title: 'Label', type: 'combobox' }}
-        selectorKey='gmail.labels'
-        selectorContext={{ workspaceId: 'workspace-1', oauthCredential: 'credential-1' }}
-        disabled
-      />
-    )
-
-    expect(html).toContain('&lt;Block.output&gt;')
-    expect(mockUseSelectorOptionDetail).toHaveBeenCalledWith(
-      'gmail.labels',
-      expect.objectContaining({ detailId: undefined, enabled: false })
-    )
-  })
 })

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/hooks/use-fetched-options.test.tsx

@@ -53,18 +53,15 @@ beforeEach(() => {
 })
 
 describe('useFetchedOptions label hydration', () => {
-  it.each([
-    { state: 'preview', isPreview: true, disabled: false },
-    { state: 'disabled', isPreview: false, disabled: true },
-  ])('keeps the list disabled but hydrates the selected value when $state', (state) => {
+  it('hydrates a selected value while a disabled control keeps list interaction off', () => {
     function Probe() {
       const result = useFetchedOptions({
         blockId: 'block-1',
         subBlockId: 'label',
         dependsOnFields: ['credential'],
         selectorKey: 'jira.issues',
-        isPreview: state.isPreview,
-        disabled: state.disabled,
+        isPreview: false,
+        disabled: true,
         valueToHydrate: 'issue-1',
         localOptions: [],
       })
@@ -82,18 +79,15 @@ describe('useFetchedOptions label hydration', () => {
     )
   })
 
-  it.each([
-    { state: 'preview', isPreview: true, disabled: false },
-    { state: 'disabled', isPreview: false, disabled: true },
-  ])('hydrates selected multi-values without enabling the list when $state', (state) => {
+  it('hydrates only eligible multi-values while preview keeps list interaction off', () => {
     function Probe() {
       const result = useFetchedOptions({
         blockId: 'block-1',
         subBlockId: 'labels',
         dependsOnFields: ['credential'],
         selectorKey: 'jira.issues',
-        isPreview: state.isPreview,
-        disabled: state.disabled,
+        isPreview: true,
+        disabled: false,
         valueToHydrate: undefined,
         valuesToHydrate: ['label-1', '{{SHARED_LABEL}}', '<Block.output>', 'local-label'],
         localOptions: [{ id: 'local-label' }],
@@ -117,10 +111,7 @@ describe('useFetchedOptions label hydration', () => {
     )
   })
 
-  it.each([
-    { state: 'preview', isPreview: true, disabled: false },
-    { state: 'disabled', isPreview: false, disabled: true },
-  ])('uses a search-free list to hydrate no-detail multi-values when $state', (state) => {
+  it('uses a search-free list to hydrate a no-detail selector while disabled', () => {
     mockUseSelectorOptions.mockReturnValue({
       data: [{ id: 'label-1', label: 'Primary label' }],
       isLoading: false,
@@ -135,8 +126,8 @@ describe('useFetchedOptions label hydration', () => {
         subBlockId: 'labels',
         dependsOnFields: ['credential'],
         selectorKey: 'gmail.labels',
-        isPreview: state.isPreview,
-        disabled: state.disabled,
+        isPreview: false,
+        disabled: true,
         valueToHydrate: undefined,
         valuesToHydrate: ['label-1', '{{SHARED_LABEL}}', '<Block.output>'],
         localOptions: [],

apps/sim/lib/imap/selector-policy.test.ts

@@ -41,32 +41,16 @@ vi.mock('@/tools/params', () => ({
 import { getToolInputParamConfigs } from '@/lib/workflows/search-replace/indexer'
 
 describe('tool-input selector fallback context', () => {
-  beforeEach(() => {
-    getSubBlocksForToolInput.mockReturnValue(null)
-  })
-
-  it('includes sibling display parameters in selector context', () => {
-    const configs = getToolInputParamConfigs({
-      tool: {
-        type: 'test',
-        operation: 'list',
-        params: {
-          credential: 'credential-1',
-          resourceId: 'resource-1',
-        },
-      },
-    })
-
-    expect(configs.find((config) => config.paramId === 'resourceId')?.selectorContext).toEqual({
-      oauthCredential: 'credential-1',
-    })
-  })
-
-  it('includes sibling display parameters when tool sub-blocks also exist', () => {
-    getSubBlocksForToolInput.mockReturnValue({
-      subBlocks: [{ id: 'message', title: 'Message', type: 'short-input' }],
-    })
+  beforeEach(() => getSubBlocksForToolInput.mockReset())
 
+  it.each([
+    ['without generated sub-blocks', null],
+    [
+      'with generated sub-blocks',
+      { subBlocks: [{ id: 'message', title: 'Message', type: 'short-input' }] },
+    ],
+  ])('includes sibling display parameters $0', (_state, subBlocksResult) => {
+    getSubBlocksForToolInput.mockReturnValue(subBlocksResult)
     const configs = getToolInputParamConfigs({
       tool: {
         type: 'test',