Skip to content

Commit dd388ad

Browse files
waleedlatif1claude
andcommitted
fix: address the third review round
Two of these were fixes from earlier rounds that never landed — the edits were in batches that aborted partway, and I reported them applied without re-verifying. The LM Studio recreate command still hard-coded the production Compose file, and the proxy table still claimed "four exceptions" above a row listing fifteen providers. The rest: - The NO_PROXY example omitted `ollama`, so on the Ollama stack local model requests would go to the external proxy. - The `lock_timeout` sentence had its trade-off backwards: it trades a table-wide stall for a failed migration, not the reverse. - `NEXT_PUBLIC_CUSTOM_CSS_URL` has to be same-origin or CSP-allowlisted; `style-src` blocks a stylesheet from another origin. - Any of a storage backend's keys activates it — a dedicated bucket, `S3_ENDPOINT`, an Azure credential — so a half-configured backend fails at startup rather than falling back to local disk. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015BwsJTEQRzWJaY4BRCkPZt
1 parent 095061b commit dd388ad

5 files changed

Lines changed: 11 additions & 5 deletions

File tree

apps/docs/content/docs/platform/enterprise/whitelabeling.mdx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,8 @@ NEXT_PUBLIC_BRAND_NAME=Acme
117117
NEXT_PUBLIC_BRAND_LOGO_URL=/branding/logo.png
118118
NEXT_PUBLIC_BRAND_WORDMARK_URL=/branding/wordmark.svg
119119
NEXT_PUBLIC_BRAND_FAVICON_URL=/branding/favicon.ico
120+
# Same-origin, or a host you have added to the CSP's style-src — a stylesheet
121+
# on another origin is blocked.
120122
NEXT_PUBLIC_CUSTOM_CSS_URL=/branding/custom.css
121123
```
122124

apps/docs/content/docs/platform/self-hosting/docker.mdx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,10 @@ VLLM_API_KEY=your_lm_studio_api_token
154154
Both the server root shown above and a URL ending in `/v1` are accepted. After recreating the `simstudio` service, its models appear in the model picker with a `vllm/` prefix; Sim removes that prefix before sending the model identifier to LM Studio.
155155

156156
```bash
157-
docker compose -f docker-compose.prod.yml up -d --force-recreate simstudio
157+
# Use the file that started your install — docker-compose.ollama.yml if you
158+
# started from the Ollama stack.
159+
COMPOSE_FILE=docker-compose.prod.yml
160+
docker compose -f "$COMPOSE_FILE" up -d --force-recreate simstudio
158161
```
159162

160163
## The `sim-setup` CLI

apps/docs/content/docs/platform/self-hosting/networking.mdx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@ The server runs on Bun, and Bun's native `fetch` honors `$HTTP_PROXY`, `$HTTPS_P
311311
312312
| Outbound path | Honors `HTTP_PROXY` / `HTTPS_PROXY` |
313313
|---|---|
314-
| Model providers reached over the default `fetch` — every provider except the four excepted below: Anthropic, OpenAI, Google/Gemini, Vertex, Groq, Cerebras, xAI, Mistral, DeepSeek, OpenRouter, Together, Fireworks, Ollama, LiteLLM, and the other OpenAI-compatible providers | Yes |
314+
| Model providers reached over the default `fetch` — Anthropic, OpenAI, Google/Gemini, Vertex, Groq, Cerebras, xAI, Mistral, DeepSeek, OpenRouter, Together, Fireworks, Ollama, LiteLLM, and the other OpenAI-compatible providers | Yes |
315315
| Email via Resend, Azure Communication Services, and Gmail sending | Yes |
316316
| The desktop update feed's calls to GitHub | Yes |
317317
| Object storage — Azure Blob and GCS | Yes — their SDK pipelines read the proxy variables |
@@ -343,7 +343,8 @@ The practical consequence: a mandatory-egress-proxy environment can route most L
343343
services:
344344
simstudio:
345345
environment:
346-
- NO_PROXY=localhost,127.0.0.1,simstudio,realtime
346+
# Add any internal model service you run: ollama, litellm, vllm.
347+
- NO_PROXY=localhost,127.0.0.1,simstudio,realtime,ollama
347348
```
348349
</Callout>
349350

apps/docs/content/docs/platform/self-hosting/object-storage.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ Set `STORAGE_PROVIDER` to `local`, `s3`, `azure`, or `gcs` to select a backend e
2727
1. **Azure Blob** — used if `AZURE_STORAGE_CONTAINER_NAME` is set **and** either (`AZURE_ACCOUNT_NAME` + `AZURE_ACCOUNT_KEY`) or `AZURE_CONNECTION_STRING` is set.
2828
2. **AWS S3** — used if `S3_BUCKET_NAME` **and** `AWS_REGION` are set (and Azure is not configured).
2929
3. **Google Cloud Storage** — used if `GCS_BUCKET_NAME` is set (and neither Azure nor S3 is configured).
30-
4. **Local disk** — used unless a cloud backend's activating variables are set: `S3_BUCKET_NAME` with `AWS_REGION` for S3, `AZURE_STORAGE_CONTAINER_NAME` for Blob, `GCS_BUCKET_NAME` for GCS. Credentials alone activate nothing.
30+
4. **Local disk** — used only when no cloud backend has been activated. Setting any of a backend's keys activates it, including a dedicated bucket, `S3_ENDPOINT`, or an Azure credential — so a half-configured backend fails at startup rather than quietly falling back here.
3131

3232
If `STORAGE_PROVIDER` is unset, Sim uses the first backend whose configuration is complete, in that order. An explicit `STORAGE_PROVIDER` takes precedence and must be valid and complete.
3333

apps/docs/content/docs/platform/self-hosting/upgrades.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ Behavior that is fixed in the migrator and not configurable, but that explains w
107107
| SQL migration retry attempts | 8, with exponential backoff and jitter, and only for a lock timeout (`55P03`). Script (data) migrations run once — a failure there exits immediately |
108108
| Connection attempts at startup | 10, for transient failures — `53300` (`too_many_connections`), `53400`, the `08xxx` connection-exception class, and socket-level errors such as `ECONNREFUSED`, `ECONNRESET`, `ETIMEDOUT`, `EHOSTUNREACH`, and `ENOTFOUND`. A database that is simply down is retried with backoff, not failed immediately |
109109

110-
The `lock_timeout` deliberately trades a failed migration for a table-wide stall: without it, DDL waiting on an `AccessExclusiveLock` queues every other query on that table behind it for the whole wait.
110+
The `lock_timeout` deliberately trades a table-wide stall for a failed migration: without it, DDL waiting on an `AccessExclusiveLock` queues every other query on that table behind it for the whole wait.
111111

112112
## Upgrade procedure
113113

0 commit comments

Comments
 (0)