Skip to content

Commit f68e066

Browse files
SK-2277: upload file request validation
1 parent bcad755 commit f68e066

1 file changed

Lines changed: 62 additions & 0 deletions

File tree

‎src/test/java/com/skyflow/vault/data/FileUploadTests.java‎

Lines changed: 62 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,47 @@ public void testMissingTable() {
115115
}
116116
}
117117

118+
@Test
119+
public void testMissingSkyflowId() {
120+
try {
121+
FileUploadRequest request = FileUploadRequest.builder()
122+
.table(table)
123+
.columnName(columnName)
124+
.fileName(fileName)
125+
.build();
126+
127+
Validations.validateFileUploadRequest(request);
128+
Assert.fail(EXCEPTION_NOT_THROWN);
129+
} catch (SkyflowException e) {
130+
Assert.assertEquals(ErrorCode.INVALID_INPUT.getCode(), e.getHttpCode());
131+
Assert.assertEquals(
132+
Utils.parameterizedString(ErrorMessage.SkyflowIdKeyError.getMessage(), Constants.SDK_PREFIX),
133+
e.getMessage()
134+
);
135+
}
136+
}
137+
138+
@Test
139+
public void testEmptySkyflowId() {
140+
try {
141+
FileUploadRequest request = FileUploadRequest.builder()
142+
.table(table)
143+
.skyflowId("")
144+
.columnName(columnName)
145+
.fileName(fileName)
146+
.build();
147+
148+
Validations.validateFileUploadRequest(request);
149+
Assert.fail(EXCEPTION_NOT_THROWN);
150+
} catch (SkyflowException e) {
151+
Assert.assertEquals(ErrorCode.INVALID_INPUT.getCode(), e.getHttpCode());
152+
Assert.assertEquals(
153+
Utils.parameterizedString(ErrorMessage.EmptySkyflowId.getMessage(), Constants.SDK_PREFIX),
154+
e.getMessage()
155+
);
156+
}
157+
}
158+
118159
@Test
119160
public void testMissingColumnName() {
120161
try {
@@ -156,4 +197,25 @@ public void testMissingFileData() {
156197
);
157198
}
158199
}
200+
201+
@Test
202+
public void testMissingFileNameWithBase64Invalid() {
203+
try {
204+
FileUploadRequest request = FileUploadRequest.builder()
205+
.table(table)
206+
.skyflowId(skyflowId)
207+
.columnName(columnName)
208+
.base64(base64Content)
209+
.build();
210+
211+
Validations.validateFileUploadRequest(request);
212+
Assert.fail(EXCEPTION_NOT_THROWN);
213+
} catch (SkyflowException e) {
214+
Assert.assertEquals(ErrorCode.INVALID_INPUT.getCode(), e.getHttpCode());
215+
Assert.assertEquals(
216+
Utils.parameterizedString(ErrorMessage.FileNameMustBeProvidedWithFileObject.getMessage(), Constants.SDK_PREFIX),
217+
e.getMessage()
218+
);
219+
}
220+
}
159221
}

0 commit comments

Comments
 (0)