Skip to content

Commit feb79cc

Browse files
SK-2954: Remove explanatory comments from a few files
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
1 parent 7f0d248 commit feb79cc

4 files changed

Lines changed: 0 additions & 13 deletions

File tree

common/client/base_skyflow.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -167,9 +167,6 @@ def detect(self, vault_id=None):
167167
return vault_config.get(OptionField.DETECT_CONTROLLER)
168168

169169
class Builder(ABC):
170-
# -- hooks, filled in per-variant by make_skyflow_class() -- left None here so using
171-
# this template directly (rather than through make_skyflow_class()) fails fast, with a
172-
# clear message (see _REQUIRED_HOOKS check in __init__ below).
173170
_vault_client_cls = None
174171
_vault_controller_cls = None
175172
_connection_cls = None
@@ -186,8 +183,6 @@ class Builder(ABC):
186183
_validate_credentials = None
187184
_set_active_log_level = None
188185

189-
# Connection/Detect support and their validators are legitimately optional per variant --
190-
# everything else must be supplied by make_skyflow_class() before this Builder is usable.
191186
_REQUIRED_HOOKS = (
192187
'_vault_client_cls', '_vault_controller_cls', '_logger_cls', '_default_log_level',
193188
'_skyflow_messages', '_skyflow_cls', '_validate_vault_config',

common/vault/base_vault_client.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,6 @@ def initialize_client_configuration(self):
5252
logger=self._logger)
5353
self._is_static_token = CredentialField.TOKEN in self._credentials or CredentialField.API_KEY in self._credentials
5454
bearer_token = self.get_bearer_token(self._credentials)
55-
# Cache unconditionally (not just on the generated-token branch) so
56-
# get_current_bearer_token() reflects static tokens/API keys too.
5755
self._bearer_token = bearer_token
5856
if needs_reinit:
5957
self.initialize_api_client(self._vault_url, bearer_token)

flowvault/skyflow_flowvault/vault/client/client.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@ def resolve_vault_url(self, cluster_id, env, vault_id, logger=None):
88
return get_vault_url(cluster_id, env, vault_id, logger=logger)
99

1010
def initialize_api_client(self, vault_url, bearer_token):
11-
# SkyflowAuth has no `token` param -- auth is injected per-call instead (see
12-
# VaultController.__build_headers).
1311
self._api_client = SkyflowAuth(base_url=vault_url)
1412

1513
def get_insert_api(self):

flowvault/skyflow_flowvault/vault/controller/_vault.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ def insert(self, request: InsertRequest) -> InsertResponse:
4646
table_name=None if needs_per_record_table else request.table,
4747
upsert=None if needs_per_record_upsert else self.__to_v1_upsert(request.upsert),
4848
)
49-
# with_raw_response so x-request-id is available to tag onto each result.
5049
raw_response = insert_api.with_raw_response.insert(
5150
vault_id=self._vault_client.get_vault_id(),
5251
records=wire_records,
@@ -84,8 +83,6 @@ def __build_wire_record(self, record, request, needs_per_record_table, needs_per
8483
))
8584

8685
def __omit_none(self, **kwargs):
87-
# A field explicitly passed as None still serializes as null; omitting the kwarg
88-
# entirely is what actually excludes it from the outgoing JSON.
8986
return {k: v for k, v in kwargs.items() if v is not None}
9087

9188
def __build_headers(self):
@@ -136,7 +133,6 @@ def __flatten_tokens(self, tokens):
136133
return flat
137134

138135
def __errors_from_exception(self, e, records, start_index):
139-
# Prefers a structured per-record error body over one flat message per batch.
140136
if isinstance(e, ApiError):
141137
request_id = self.__extract_request_id(e.headers)
142138
body = e.body if isinstance(e.body, dict) else None

0 commit comments

Comments
 (0)