Skip to content

Commit 4a0f623

Browse files
Noah-SilveraforkataadammathysAlistairNormanbenjaminwil
committed
Write down conversation about blowing up on persistence
Co-authored-by: Chris Todorov <[email protected]> Co-authored-by: Adam Mueller <[email protected]> Co-authored-by: Alistair Norman <[email protected]> Co-authored-by: benjamin wil <[email protected]> Co-authored-by: Harmony Bouvier <[email protected]> Co-authored-by: Kendra Riga <[email protected]> Co-authored-by: Senem <[email protected]>
1 parent 43d7029 commit 4a0f623

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

TODO.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,3 +11,10 @@ In-Memory Order Updater TODO
1111

1212
- [ ] Test coverage to ensure state changes aren't persisted (if someone changes current implementation)
1313
- [ ] Should we blow up if something tries to persist?
14+
- Some thoughts from the initial conservation
15+
- "By calling this in memory order updater, we are making a contract with the user that it will be in memory"
16+
- "This is really something which theoritically should be covered in tests"
17+
- "Our inMemoryOrderUpdater probably shouldnt take a persist true flag"
18+
- thinking about other changes to solidus deep in the stack
19+
- thinking about users configuring all the configurable classes
20+

0 commit comments

Comments
 (0)