Skip to content

fix(deps): bump protobuf to 6.33.6 for VULN-88809#129

Open
shuningc wants to merge 1 commit into
mainfrom
VULN-88809-protobuf-upgrade
Open

fix(deps): bump protobuf to 6.33.6 for VULN-88809#129
shuningc wants to merge 1 commit into
mainfrom
VULN-88809-protobuf-upgrade

Conversation

@shuningc

Copy link
Copy Markdown
Contributor

Summary

  • Remediate VULN-88809: ParseDict() DoS where max_recursion_depth is bypassed via nested google.protobuf.Any messages.
  • poetry.lock: protobuf 6.31.1 → 6.33.6 (transitive; capped <7.0.0 by dependents; no pyproject change).
  • Example pin elastic-chatbot-rag-app/requirements.txt: protobuf==5.29.6 (latest patched 5.x).

Test plan

  • poetry check
  • Installed protobuf 6.33.6; poetry run pytest tests/ (1988 passed, 10 skipped)

Jira

VULN-88809

Remediate the ParseDict() DoS where max_recursion_depth can be bypassed via
nested google.protobuf.Any messages. Lock-only bump in main (transitive, capped
<7 by dependents); example pin moved to 5.29.6 on the 5.x line.

Co-authored-by: Cursor <cursoragent@cursor.com>
@etserend

Copy link
Copy Markdown
Contributor

Code Review — AI-Assisted Feedback

Reviewed by Claude Code (Claude Opus), automated review to assist human reviewers.

Verdict: Approve

Minimal, well-scoped fix. The dual-track patching strategy is correct and worth calling out explicitly.


P3 — Dual-track patching (5.x + 6.x) not explained in PR description (Claude Code)

File/Section: poetry.lock vs examples/rag/elastic-chatbot-rag-app/requirements.txt
Issue: The main lockfile moves to protobuf 6.33.6 while the example pin stays on the 5.x line (5.29.3 → 5.29.6). This is the correct strategy — google-cloud-aiplatform dependents cap at <6.0.0 — but the PR description doesn't explain the two-track approach, which could confuse future reviewers.
Evidence: PR description notes "capped <7.0.0 by dependents"; both 5.29.5+ and 6.31.1+ received the CVE fix for VULN-88809.
Recommended fix: Add a brief note to the PR description explaining why both 5.x and 6.x lines are patched independently.


Reviewer Model Key Contribution
Claude Code Claude Opus Flagged undocumented dual-track patching rationale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants