Skip to content

Windows: Git delivery watcher spawns visible git console windows #32

Description

@symmr

On Windows, Token Meter flashes git console windows while running.
Similar to #19, but different call site.

The Git delivery watcher calls subprocess.run(["git", ...]) in GitDeliveryService._subprocess_runner() (token_meter/services/git_delivery.py) with no CREATE_NO_WINDOW.
Every 5 minutes, each scan opens and closes many console windows.

Suggested fix

Change GitDeliveryService._subprocess_runner() so subprocess.run gets the same kwargs _run_update_git() already passes via _platform_subprocess_kwargs() (token_meter/app.py).
On Windows those kwargs are creationflags=CREATE_NO_WINDOW (0x08000000) and close_fds=True, from WindowsPlatformServices.process_options().

Environment

  • Windows 11 Pro, 10.0.26200
  • Token Meter aa309c0 (main)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions