Update js files for newer closure-compiler

pcj · pcj · commit 33c59bc5ae06 · 2025-11-19T16:09:48.000-07:00
diff --git a/js/ui/BUILD.bazel b/js/ui/BUILD.bazel
@@ -4,30 +4,28 @@ package(default_visibility = ["//visibility:public"])
 
 closure_js_library(
     name = "core",
-    srcs = [
-        "core.js",
-    ],
+    srcs = ["core.js"],
     deps = [
         ":history",
         ":injector",
         ":keyboard",
-        "@com_google_javascript_closure_library//closure/goog/asserts",
-        "@com_google_javascript_closure_library//closure/goog/asserts:dom",
-        "@com_google_javascript_closure_library//closure/goog/dom",
-        "@com_google_javascript_closure_library//closure/goog/events",
-        "@com_google_javascript_closure_library//closure/goog/events:eventhandler",
-        "@com_google_javascript_closure_library//closure/goog/events:eventtarget",
-        "@com_google_javascript_closure_library//closure/goog/fx:dom",
-        "@com_google_javascript_closure_library//closure/goog/fx:easing",
-        "@com_google_javascript_closure_library//closure/goog/history:event",
-        "@com_google_javascript_closure_library//closure/goog/history:eventtype",
-        "@com_google_javascript_closure_library//closure/goog/object",
-        "@com_google_javascript_closure_library//closure/goog/promise",
-        "@com_google_javascript_closure_library//closure/goog/promise:resolver",
-        "@com_google_javascript_closure_library//closure/goog/string",
-        "@com_google_javascript_closure_library//closure/goog/style",
-        "@com_google_javascript_closure_library//closure/goog/ui:component",
-        "@com_google_javascript_closure_library//closure/goog/ui:control",
+        "@io_bazel_rules_closure//closure/goog/asserts",
+        "@io_bazel_rules_closure//closure/goog/asserts:dom",
+        "@io_bazel_rules_closure//closure/goog/dom",
+        "@io_bazel_rules_closure//closure/goog/events",
+        "@io_bazel_rules_closure//closure/goog/events:eventhandler",
+        "@io_bazel_rules_closure//closure/goog/events:eventtarget",
+        "@io_bazel_rules_closure//closure/goog/fx:dom",
+        "@io_bazel_rules_closure//closure/goog/fx:easing",
+        "@io_bazel_rules_closure//closure/goog/history:event",
+        "@io_bazel_rules_closure//closure/goog/history:eventtype",
+        "@io_bazel_rules_closure//closure/goog/object",
+        "@io_bazel_rules_closure//closure/goog/promise",
+        "@io_bazel_rules_closure//closure/goog/promise:resolver",
+        "@io_bazel_rules_closure//closure/goog/string",
+        "@io_bazel_rules_closure//closure/goog/style",
+        "@io_bazel_rules_closure//closure/goog/ui:component",
+        "@io_bazel_rules_closure//closure/goog/ui:control",
     ],
 )
 
@@ -38,42 +36,38 @@ closure_js_library(
         "history/event.js",
     ],
     deps = [
-        "@com_google_javascript_closure_library//closure/goog/asserts:dom",
-        "@com_google_javascript_closure_library//closure/goog/dom",
-        "@com_google_javascript_closure_library//closure/goog/dom:tagname",
-        "@com_google_javascript_closure_library//closure/goog/events",
-        "@com_google_javascript_closure_library//closure/goog/events:event",
-        "@com_google_javascript_closure_library//closure/goog/events:eventtarget",
-        "@com_google_javascript_closure_library//closure/goog/events:eventtype",
-        "@com_google_javascript_closure_library//closure/goog/history:event",
-        "@com_google_javascript_closure_library//closure/goog/history:eventtype",
-        "@com_google_javascript_closure_library//closure/goog/history:html5history",
-        "@com_google_javascript_closure_library//closure/goog/string",
+        "@io_bazel_rules_closure//closure/goog/asserts:dom",
+        "@io_bazel_rules_closure//closure/goog/dom",
+        "@io_bazel_rules_closure//closure/goog/dom:tagname",
+        "@io_bazel_rules_closure//closure/goog/events",
+        "@io_bazel_rules_closure//closure/goog/events:event",
+        "@io_bazel_rules_closure//closure/goog/events:eventtarget",
+        "@io_bazel_rules_closure//closure/goog/events:eventtype",
+        "@io_bazel_rules_closure//closure/goog/history:event",
+        "@io_bazel_rules_closure//closure/goog/history:eventtype",
+        "@io_bazel_rules_closure//closure/goog/history:html5history",
+        "@io_bazel_rules_closure//closure/goog/string",
     ],
 )
 
 closure_js_library(
     name = "keyboard",
-    srcs = [
-        "keyboard.js",
-    ],
+    srcs = ["keyboard.js"],
     deps = [
-        "@com_google_javascript_closure_library//closure/goog/disposable",
-        "@com_google_javascript_closure_library//closure/goog/events",
-        "@com_google_javascript_closure_library//closure/goog/object",
-        "@com_google_javascript_closure_library//closure/goog/ui:keyboardshortcuthandler",
+        "@io_bazel_rules_closure//closure/goog/disposable",
+        "@io_bazel_rules_closure//closure/goog/events",
+        "@io_bazel_rules_closure//closure/goog/object",
+        "@io_bazel_rules_closure//closure/goog/ui:keyboardshortcuthandler",
     ],
 )
 
 closure_js_library(
     name = "template",
-    srcs = [
-        "template.js",
-    ],
+    srcs = ["template.js"],
     deps = [
         ":core",
-        "@com_google_javascript_closure_library//closure/goog/dom",
-        "@com_google_javascript_closure_library//closure/goog/soy",
+        "@io_bazel_rules_closure//closure/goog/dom",
+        "@io_bazel_rules_closure//closure/goog/soy",
     ],
 )
 
@@ -88,31 +82,29 @@ closure_js_library(
     deps = [
         ":core",
         ":template",
-        "@com_google_javascript_closure_library//closure/goog/asserts",
-        "@com_google_javascript_closure_library//closure/goog/dom",
-        "@com_google_javascript_closure_library//closure/goog/dom:classlist",
-        "@com_google_javascript_closure_library//closure/goog/dom:dataset",
-        "@com_google_javascript_closure_library//closure/goog/dom:tagname",
-        "@com_google_javascript_closure_library//closure/goog/events:event",
+        "@io_bazel_rules_closure//closure/goog/asserts",
+        "@io_bazel_rules_closure//closure/goog/dom",
+        "@io_bazel_rules_closure//closure/goog/dom:classlist",
+        "@io_bazel_rules_closure//closure/goog/dom:dataset",
+        "@io_bazel_rules_closure//closure/goog/dom:tagname",
+        "@io_bazel_rules_closure//closure/goog/events:event",
     ],
 )
 
 closure_js_library(
     name = "menushield",
-    srcs = [
-        "menushield.js",
-    ],
+    srcs = ["menushield.js"],
     deps = [
-        "@com_google_javascript_closure_library//closure/goog/asserts",
-        "@com_google_javascript_closure_library//closure/goog/dom",
-        "@com_google_javascript_closure_library//closure/goog/events",
-        "@com_google_javascript_closure_library//closure/goog/math:coordinate",
-        "@com_google_javascript_closure_library//closure/goog/style",
-        "@com_google_javascript_closure_library//closure/goog/ui:component",
-        "@com_google_javascript_closure_library//closure/goog/ui:container",
-        "@com_google_javascript_closure_library//closure/goog/ui:menu",
-        "@com_google_javascript_closure_library//closure/goog/ui:menubutton",
-        "@com_google_javascript_closure_library//closure/goog/ui:submenu",
+        "@io_bazel_rules_closure//closure/goog/asserts",
+        "@io_bazel_rules_closure//closure/goog/dom",
+        "@io_bazel_rules_closure//closure/goog/events",
+        "@io_bazel_rules_closure//closure/goog/math:coordinate",
+        "@io_bazel_rules_closure//closure/goog/style",
+        "@io_bazel_rules_closure//closure/goog/ui:component",
+        "@io_bazel_rules_closure//closure/goog/ui:container",
+        "@io_bazel_rules_closure//closure/goog/ui:menu",
+        "@io_bazel_rules_closure//closure/goog/ui:menubutton",
+        "@io_bazel_rules_closure//closure/goog/ui:submenu",
     ],
 )
 
@@ -124,17 +116,15 @@ closure_js_library(
     ],
     deps = [
         ":core",
-        "@com_google_javascript_closure_library//closure/goog/asserts",
-        "@com_google_javascript_closure_library//closure/goog/asserts:dom",
-        "@com_google_javascript_closure_library//closure/goog/dom",
+        "@io_bazel_rules_closure//closure/goog/asserts",
+        "@io_bazel_rules_closure//closure/goog/asserts:dom",
+        "@io_bazel_rules_closure//closure/goog/dom",
     ],
 )
 
 closure_js_library(
     name = "injector",
-    srcs = [
-        "injector.js",
-    ],
+    srcs = ["injector.js"],
     deps = [
         # ":core",
     ],
@@ -151,11 +141,11 @@ closure_js_library(
         ":select",
         ":syntax",
         ":template",
-        "@com_google_javascript_closure_library//closure/goog/asserts",
-        "@com_google_javascript_closure_library//closure/goog/dom",
-        "@com_google_javascript_closure_library//closure/goog/history:eventtype",
-        "@com_google_javascript_closure_library//closure/goog/object",
-        "@com_google_javascript_closure_library//closure/goog/promise",
+        "@io_bazel_rules_closure//closure/goog/asserts",
+        "@io_bazel_rules_closure//closure/goog/dom",
+        "@io_bazel_rules_closure//closure/goog/history:eventtype",
+        "@io_bazel_rules_closure//closure/goog/object",
+        "@io_bazel_rules_closure//closure/goog/promise",
     ],
 )
 
@@ -167,22 +157,17 @@ closure_js_test(
     entry_points = ["goog:stack.ui.ComponentTest"],
     deps = [
         ":ui",
-        "@io_bazel_rules_closure//closure/library",
         "@io_bazel_rules_closure//closure/library:testing",
     ],
 )
 
 closure_js_test(
     name = "route_test",
-    srcs = [
-        "route_test.js",
-    ],
+    srcs = ["route_test.js"],
     entry_points = ["goog:stack.ui.RouteTest"],
     deps = [
         ":core",
         ":select",
-        ":app",
-        # "@io_bazel_rules_closure//closure/library",
         "@io_bazel_rules_closure//closure/library:testing",
     ],
 )
@@ -195,10 +180,10 @@ closure_js_test(
     entry_points = ["goog:stack.ui.HistoryTest"],
     deps = [
         ":history",
-        "@com_google_javascript_closure_library//closure/goog/dom",
-        "@com_google_javascript_closure_library//closure/goog/dom:tagname",
-        "@com_google_javascript_closure_library//closure/goog/events",
-        "@com_google_javascript_closure_library//closure/goog/string",
+        "@io_bazel_rules_closure//closure/goog/dom",
+        "@io_bazel_rules_closure//closure/goog/dom:tagname",
+        "@io_bazel_rules_closure//closure/goog/events",
+        "@io_bazel_rules_closure//closure/goog/string",
         "@io_bazel_rules_closure//closure/library:testing",
     ],
 )
diff --git a/js/ui/app.js b/js/ui/app.js
@@ -166,7 +166,7 @@ class App extends Component {
    * @param {!Array<string>} path
    */
   setLocation(path) {
-    //console.log('setLocation', path);
+    // console.log('setLocation', path);
     this.history_.setLocation(path.join('/'));
   }
 
diff --git a/js/ui/core.js b/js/ui/core.js
@@ -710,13 +710,10 @@ class Component extends GoogUiComponent {
     getMenuItems() {
         return null;
     }
-
 }
-
 exports.Component = Component;
 
 class App extends Component {
-
     /**
      * @param {?dom.DomHelper=} opt_domHelper
      */
@@ -823,7 +820,10 @@ class App extends Component {
         return asserts.assertObject(this.components_[name]);
     }
 
-    /** @override */
+    /**
+     * @override
+     * @param {!Route} route
+     */
     go(route) {
         //route.touch(this);
         super.go(route);
diff --git a/js/ui/route.js b/js/ui/route.js
@@ -220,7 +220,7 @@ class Route extends EventTarget {
     this.assertInProgress();
     var index = this.index_++;
     this.progress_[index] = component;
-    //console.log(`progress made: ${index}, ${this.path_[index]} ${this.unmatchedPath()}`, component);
+    // console.log(`progress made: ${index}, ${this.path_[index]} ${this.unmatchedPath()}`, component);
     component.show();
     this.notifyEvent(Route.EventType.PROGRESS, component);
   }
diff --git a/js/ui/router.js b/js/ui/router.js
@@ -49,7 +49,6 @@ class Router extends EventTarget {
      * @type {boolean}
      */
     this.strict_ = true;
-
   }
 
   /**
diff --git a/js/ui/select.js b/js/ui/select.js
@@ -136,6 +136,7 @@ class Select extends Component {
 
   /**
    * @override
+   * @param {!Route} route
    */
   goHere(route) {
     if (this.current_) {
@@ -154,6 +155,7 @@ class Select extends Component {
 
   /**
    * @override
+   * @param {!Route} route
    */
   goDown(route) {
     var name = route.peek();
diff --git a/js/ui/tab.js b/js/ui/tab.js
@@ -29,6 +29,8 @@ class Tab extends Select {
 
   /**
    * @override
+   * @param {string} name
+   * @param {!Route} route
    */
   selectFail(name, route) {
     this.failHandler_(name, route);
diff --git a/js/ui/tabs.js b/js/ui/tabs.js

Original file line number	Diff line number	Diff line change
`@@ -166,7 +166,7 @@ class App extends Component {`
`166`	`166`	`* @param {!Array<string>} path`
`167`	`167`	`*/`
`168`	`168`	`setLocation(path) {`
`169`		`- //console.log('setLocation', path);`
	`169`	`+ // console.log('setLocation', path);`
`170`	`170`	`this.history_.setLocation(path.join('/'));`
`171`	`171`	`}`
`172`	`172`
Original file line number	Diff line number	Diff line change
`@@ -220,7 +220,7 @@ class Route extends EventTarget {`
`220`	`220`	`this.assertInProgress();`
`221`	`221`	`var index = this.index_++;`
`222`	`222`	`this.progress_[index] = component;`
`223`		- //console.log(`progress made: ${index}, ${this.path_[index]} ${this.unmatchedPath()}`, component);
	`223`	+ // console.log(`progress made: ${index}, ${this.path_[index]} ${this.unmatchedPath()}`, component);
`224`	`224`	`component.show();`
`225`	`225`	`this.notifyEvent(Route.EventType.PROGRESS, component);`
`226`	`226`	`}`
Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,6 @@ class Router extends EventTarget {`
`49`	`49`	`* @type {boolean}`
`50`	`50`	`*/`
`51`	`51`	`this.strict_ = true;`
`52`		`-`
`53`	`52`	`}`
`54`	`53`
`55`	`54`	`/**`