Skip to content

Latest commit

 

History

History
280 lines (196 loc) · 10.4 KB

CONTRIBUTING.rst

File metadata and controls

280 lines (196 loc) · 10.4 KB

Contributing

Welcome to libdeye contributor's guide.

This document focuses on getting any potential contributor familiarized with the development processes, but other kinds of contributions are also appreciated.

If you are new to using git or have never collaborated in a project previously, please have a look at contribution-guide.org. Other resources are also listed in the excellent guide created by FreeCodeCamp [1].

Please notice, all users and contributors are expected to be open, considerate, reasonable, and respectful. When in doubt, Python Software Foundation's Code of Conduct is a good reference in terms of behavior guidelines.

Issue Reports

If you experience bugs or general issues with libdeye, please have a look on the issue tracker. If you don't see anything useful there, please feel free to fire an issue report.

Tip

Please don't forget to include the closed issues in your search. Sometimes a solution was already reported, and the problem is considered solved.

New issue reports should include information about your programming environment (e.g., operating system, Python version) and steps to reproduce the problem. Please try also to simplify the reproduction steps to a very minimal example that still illustrates the problem you are facing. By removing other factors, you help us to identify the root cause of the issue.

Documentation Improvements

You can help improve libdeye docs by making them more readable and coherent, or by adding missing information and correcting mistakes.

libdeye documentation uses Sphinx as its main documentation compiler. This means that the docs are kept in the same repository as the project code, and that any documentation update is done in the same way was a code contribution.

Tip

Please notice that the GitHub web interface provides a quick way of propose changes in libdeye's files. While this mechanism can be tricky for normal code contributions, it works perfectly fine for contributing to the docs, and can be quite handy.

If you are interested in trying this method out, please navigate to the docs folder in the source repository, find which file you would like to propose changes and click in the little pencil icon at the top, to open GitHub's code editor. Once you finish editing the file, please write a message in the form at the bottom of the page describing which changes have you made and what are the motivations behind them and submit your proposal.

When working on documentation changes in your local machine, you can compile them using uv:

uv run --group docs sphinx-build -b html docs docs/_build/html

and use Python's built-in web server for a preview in your web browser (http://localhost:8000):

python3 -m http.server --directory 'docs/_build/html'

Code Contributions

Submit an issue

Before you work on any non-trivial code contribution it's best to first create a report in the issue tracker to start a discussion on the subject. This often provides additional considerations and avoids unnecessary work.

Clone the repository

  1. Create an user account on GitHub if you do not already have one.

  2. Fork the project repository: click on the Fork button near the top of the page. This creates a copy of the code under your account on GitHub.

  3. Clone this copy to your local disk:

    git clone git@github.com:stackia/libdeye.git
    cd libdeye
    

Create an environment

This project uses uv to manage Python versions, a project virtual environment, and locked dependencies. Install uv from https://docs.astral.sh/uv/getting-started/installation/, then from the repository root run:

uv sync

uv sync creates .venv, installs the project in editable mode, and installs the default dev dependency group from uv.lock. After that, uv run python can import the package under development.

Setup pre-commit:

uv run pre-commit install

libdeye comes with a lot of hooks configured to automatically help the developer to check the code being written.

Implement your changes

  1. Create a branch to hold your changes:

    git checkout -b my-feature
    

    and start making changes. Never work on the main branch!

  2. Start your work on this branch. Don't forget to add docstrings to new functions, modules and classes, especially if they are part of public APIs.

  3. Add yourself to the list of contributors in AUTHORS.rst.

  4. When you’re done editing, do:

    git add <MODIFIED FILES>
    git commit
    

    to record your changes in git.

    Please make sure to see the validation messages from pre-commit and fix any eventual issues. This should automatically use ruff to check/fix the code style in a way that is compatible with Home Assistant core.

    Important

    Don't forget to add unit tests and documentation in case your contribution adds an additional feature and is not just a bugfix.

    Moreover, writing a descriptive commit message is highly recommended. In case of doubt, you can check the commit history with:

    git log --graph --decorate --pretty=oneline --abbrev-commit --all
    

    to look for recurring communication patterns.

  5. Please check that your changes don't break any unit tests with:

    uv run pytest
    

    Other common tasks:

    • Lint: uv run pre-commit run --all-files
    • Type check: uv run mypy .
    • Pylint: uv run pylint src/libdeye tests
    • Build docs: uv run --group docs sphinx-build -b html docs docs/_build/html
    • Build distributions: uv build

Submit your contribution

  1. If everything works fine, push your local branch to GitHub with:

    git push -u origin my-feature
    
  2. Go to the web page of your fork and click "Create pull request" to send your changes for review.

Find more detailed information in creating a PR. You might also want to open the PR as a draft first and mark it as ready for review after the feedbacks from the continuous integration (CI) system or any required fixes.

Troubleshooting

The following tips can be used when facing problems to build or test the package:

  1. Make sure to fetch all the tags from the upstream repository. The command git describe --abbrev=0 --tags should return the version you are expecting. If you are trying to run CI scripts in a fork repository, make sure to push all the tags. Recreate the environment with uv sync --reinstall if the local checkout looks stale.

  2. If a newly added dependency is missing after editing pyproject.toml, refresh the lockfile and environment:

    uv lock
    uv sync
    

    To rebuild documentation after changing the docs group:

    uv sync --group docs
    uv run --group docs sphinx-build -b html docs docs/_build/html
    
  3. Make sure uv is using the Python version pinned in .python-version (currently 3.14). When in doubt you can run:

    uv python pin
    uv run python --version
    
  4. Pytest can drop you in an interactive session in the case an error occurs. In order to do that you need to pass a --pdb option (for example by running uv run pytest -k <NAME OF THE FALLING TEST> --pdb). You can also setup breakpoints manually instead of using the --pdb option.

Maintainer tasks

Releases

If instead you are using a different/private package index, please update the instructions accordingly.

If you are part of the group of maintainers and have correct user permissions on PyPI, the following steps can be used to release a new version for libdeye:

  1. Make sure all unit tests are successful.
  2. Tag the current commit on the main branch with a release tag matching existing tags, e.g., 3.0.0 (no v prefix).
  3. Push the new tag to the upstream repository, e.g., git push origin 3.0.0. Pushing the tag runs Publish to PyPI.
  4. Clean up the dist and build folders (rm -rf dist build) to avoid confusion with old builds and Sphinx docs.
  5. Run uv build --no-sources and check that the files in dist have the correct version (no .dirty or git hash) according to the git tag. Also check the sizes of the distributions, if they are too big (e.g., > 500KB), unwanted clutter may have been accidentally included.
  6. Run uv publish and check that everything was uploaded to PyPI correctly.
[1]Even though, these resources focus on open source projects and communities, the general ideas behind collaborating with other developers to collectively create software are general and can be applied to all sorts of environments, including private companies and proprietary code bases.