changes per review

Author: mitzimorris

jupyter/sum-to-zero/stan/bym2_multicomp.stan

@@ -7,14 +7,14 @@ functions {
    * @param sizes component sizes
    * @return vector phi_ozs, the vector whose slices sum to zero
    */
-  vector zero_sum_components_lp(vector phi, array[ , ] int idxs, array[] int sizes) {
+  vector zero_sum_components(vector phi, array[ , ] int idxs, array[] int sizes) {
     vector[sum(sizes)] phi_ozs;
     int idx_phi = 1;
     int idx_ozs = 1;
     for (i in 1:size(sizes)) {
       int n = sizes[i];
       phi_ozs[idx_ozs : idx_ozs + n - 1] = 
-        zero_sum_constrain_lp(segment(phi, idx_phi, n - 1));
+        zero_sum_constrain(segment(phi, idx_phi, n - 1));
       idx_phi += n - 1;
       idx_ozs += n;
     }
@@ -27,7 +27,7 @@ functions {
    * @param y unconstrained zero-sum parameters
    * @return vector z, the vector whose slices sum to zero
    */
-  vector zero_sum_constrain_lp(vector y) {
+  vector zero_sum_constrain(vector y) {
     int N = num_elements(y);
     vector[N + 1] z = zeros_vector(N + 1);
     real sum_w = 0;
@@ -101,7 +101,7 @@ parameters {
 }
 
 transformed parameters {
-  vector[N_connected] phi = zero_sum_components_lp(phi_raw, component_idxs, component_sizes);
+  vector[N_connected] phi = zero_sum_components(phi_raw, component_idxs, component_sizes);
   vector[N] gamma;  // BYM2, per Freni-Sterrantino
   gamma[1 : N_connected] = sqrt(1 - rho) * theta + sqrt(rho * inv(taus)) .* phi;
   gamma[N_connected + 1 : N] = singletons_re;