fix: Don't crash on hydratable serialization failures (#17315)

* fix: Don't crash on `hydratable` serialization failures

* better

* Update two-lizards-poke.md

Co-authored-by: Ben McCann <[email protected]>

---------

Co-authored-by: Ben McCann <[email protected]>

Author: elliott-with-the-longest-name-on-github

.changeset/two-lizards-poke.md

@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: don't crash on `hydratable` serialization failure

packages/svelte/src/internal/server/hydratable.js

@@ -57,32 +57,28 @@ function encode(key, value, unresolved) {
 
 	entry.serialized = devalue.uneval(entry.value, (value, uneval) => {
 		if (is_promise(value)) {
+			// we serialize promises as `"${i}"`, because it's impossible for that string
+			// to occur 'naturally' (since the quote marks would have to be escaped)
+			// this placeholder is returned synchronously from `uneval`, which includes it in the
+			// serialized string. Later (at least one microtask from now), when `p.then` runs, it'll
+			// be replaced.
+			const placeholder = `"${uid++}"`;
 			const p = value
-				.then((v) => `r(${uneval(v)})`)
+				.then((v) => {
+					entry.serialized = entry.serialized.replace(placeholder, `r(${uneval(v)})`);
+				})
 				.catch((devalue_error) =>
 					e.hydratable_serialization_failed(
 						key,
 						serialization_stack(entry.stack, devalue_error?.stack)
 					)
 				);
 
-			// prevent unhandled rejections from crashing the server
-			p.catch(() => {});
-
-			// track which promises are still resolving when render is complete
 			unresolved?.set(p, key);
-			p.finally(() => unresolved?.delete(p));
-
-			// we serialize promises as `"${i}"`, because it's impossible for that string
-			// to occur 'naturally' (since the quote marks would have to be escaped)
-			const placeholder = `"${uid++}"`;
-
-			(entry.promises ??= []).push(
-				p.then((s) => {
-					entry.serialized = entry.serialized.replace(placeholder, s);
-				})
-			);
+			// prevent unhandled rejections from crashing the server, track which promises are still resolving when render is complete
+			p.catch(() => {}).finally(() => unresolved?.delete(p));
 
+			(entry.promises ??= []).push(p);
 			return placeholder;
 		}
 	});

packages/svelte/tests/server-side-rendering/samples/hydratable-unserializable/_config.js

@@ -0,0 +1,6 @@
+import { test } from '../../test';
+
+export default test({
+	mode: ['async'],
+	error: 'hydratable_serialization_failed'
+});

packages/svelte/tests/server-side-rendering/samples/hydratable-unserializable/main.svelte

@@ -0,0 +1,5 @@
+<script lang="ts">
+    import { hydratable } from 'svelte';
+
+    hydratable('key', () => new Promise(() => { throw new Error('nope') }));
+</script>