Skip to content

Commit a70217f

Browse files
committed
[lldb] Allow LLDBMemoryReader to provide symbols outside refl. sections
There are swift metadata symbols outside the "__swift_" sections. For example, swift context descriptors live in the "const" sections. Allow LLDBMemoryReader::resolvePointerAsSymbol to return any symbol that it finds. rdar://165950673
1 parent da0f781 commit a70217f

File tree

1 file changed

+0
-13
lines changed

1 file changed

+0
-13
lines changed

lldb/source/Plugins/LanguageRuntime/Swift/LLDBMemoryReader.cpp

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -195,19 +195,6 @@ LLDBMemoryReader::resolvePointerAsSymbol(swift::remote::RemoteAddress address) {
195195
return {};
196196
}
197197

198-
if (auto section_sp = addr.GetSection()) {
199-
if (auto *obj_file = section_sp->GetObjectFile()) {
200-
auto obj_file_format_type =
201-
obj_file->GetArchitecture().GetTriple().getObjectFormat();
202-
if (auto swift_obj_file_format =
203-
GetSwiftObjectFileFormat(obj_file_format_type)) {
204-
if (!swift_obj_file_format->sectionContainsReflectionData(
205-
section_sp->GetName().GetStringRef()))
206-
return {};
207-
}
208-
}
209-
}
210-
211198
if (auto *symbol = addr.CalculateSymbolContextSymbol()) {
212199
auto mangledName = symbol->GetMangled().GetMangledName().GetStringRef();
213200
// MemoryReader requires this to be a Swift symbol. LLDB can also be

0 commit comments

Comments
 (0)