[NFC] BridgeJS: Remove added implementation and test comments

Author: krodak

Plugins/BridgeJS/Sources/BridgeJSCore/ExportSwift.swift

@@ -1478,14 +1478,6 @@ struct ProtocolCodegen {
             externDecls.append(contentsOf: propertyExternDecls)
         }
 
-        // The JS-backed implementations live on the protocol itself, constrained
-        // to wrapper types. A refining protocol's wrapper (`AnyC` for
-        // `C: A, B`) then satisfies A's and B's requirements through their
-        // extensions: Swift's conformance resolution does the "flattening",
-        // every extern stays owned by the protocol that declares the member,
-        // and a member the refining protocol re-declares resolves to the more
-        // specific extension. User conformers never see these defaults - they
-        // do not conform to `_BridgedSwiftProtocolWrapper`.
         var decls: [DeclSyntax] = []
         if !methodDecls.isEmpty || !propertyDecls.isEmpty {
             let extensionPrinter = CodeFragmentPrinter()

Plugins/BridgeJS/Sources/BridgeJSCore/SwiftToSkeleton.swift

@@ -3564,7 +3564,7 @@ private final class ImportSwiftMacrosAPICollector: SyntaxAnyVisitor {
 
     // MARK: - Parsing Methods
 
-    /// Validates and collects the generic parameters of an imported
+    /// Validates and collects the generic parameter names of an imported
     /// `@JSFunction` declaration (function, method or initializer).
     ///
     /// Returns `nil` when a diagnostic was emitted; an empty array when the

Plugins/BridgeJS/Sources/BridgeJSLink/BridgeJSLink.swift

@@ -1021,9 +1021,6 @@ public struct BridgeJSLink {
         for skeleton in exportedSkeletons {
             for proto in skeleton.protocols {
                 printer.write(lines: renderJSDoc(documentation: proto.documentation, parameters: []))
-                // Inherited requirements come from `extends`, mirroring the Swift
-                // side where the refining wrapper picks them up from the base
-                // protocols' extensions.
                 let extendsClause =
                     inheritedProtocolTSNames(of: proto, in: exportedSkeletons)
                     .map { " extends \($0.joined(separator: ", "))" } ?? ""
@@ -1687,9 +1684,6 @@ public struct BridgeJSLink {
         }
     }
 
-    /// Resolves public TypeScript names without changing the skeleton's Swift type identities.
-    /// TypeScript names of the `@JS` protocols `proto` refines, resolved across
-    /// every linked skeleton so a renamed base protocol renders as its JS name.
     private func inheritedProtocolTSNames(of proto: ExportedProtocol, in skeletons: [ExportedSkeleton]) -> [String]? {
         guard let inherited = proto.inheritedJSProtocols, !inherited.isEmpty else { return nil }
         return inherited.map { baseName in
@@ -1702,6 +1696,7 @@ public struct BridgeJSLink {
         }
     }
 
+    /// Resolves public TypeScript names without changing the skeleton's Swift type identities.
     private func resolveTypeScriptType(_ type: BridgeType) -> String {
         return Self.resolveTypeScriptType(type, exportedSkeletons: skeletons.compactMap(\.exported))
     }

Plugins/BridgeJS/Tests/BridgeJSToolTests/GenericImportDiagnosticsTests.swift

@@ -62,8 +62,6 @@ import Testing
         )
         let exported = try #require(skeleton.exported)
         let node = try #require(exported.protocols.first { $0.name == "Node" })
-        // The skeleton records only what each protocol declares plus the
-        // refinement edge; inherited requirements are not copied.
         #expect(node.methods.isEmpty)
         #expect(node.properties.map(\.name) == ["value"])
         #expect(node.inheritedJSProtocols == ["Middle"])
@@ -76,12 +74,9 @@ import Testing
         let glue = try #require(
             try ExportSwift(progress: .silent, moduleName: skeleton.moduleName, skeleton: exported).finalize()
         )
-        // Implementations live on the declaring protocol, constrained to
-        // wrappers, so AnyNode inherits Base's `read`/`value` through the
-        // extension instead of carrying copies with re-namespaced externs.
         #expect(glue.contains("extension Base where Self: _BridgedSwiftProtocolWrapper {"))
         #expect(glue.contains("extension Node where Self: _BridgedSwiftProtocolWrapper {"))
-        #expect(!glue.contains("extension Middle where Self"))  // nothing declared, nothing emitted
+        #expect(!glue.contains("extension Middle where Self"))
         #expect(glue.contains("struct AnyNode: Node, _BridgedSwiftProtocolWrapper {"))
         #expect(glue.contains("name: \"bjs_Base_read\""))
         #expect(!glue.contains("bjs_Node_read"))

Tests/BridgeJSRuntimeTests/ImportGenericAPIs.swift

@@ -306,13 +306,6 @@ extension GenericRTPoint: GenericRTNode {
     }
 }
 
-// Protocol refinement is resolved by Swift, not by copying members: the
-// wrapper for a refining protocol picks up inherited requirements from the
-// base protocols' constrained extensions. This fixture covers the shapes
-// that used to need special handling in the generator: two parents, a
-// member re-declared by the refiner, and a `{ get set }` requirement
-// inherited unchanged. (Re-declaring an inherited `{ get set }` as `{ get }`
-// is rejected by Swift itself, so the generator never sees it.)
 @JS protocol RefineIdentified {
     var id: String { get }
     var score: Int { get set }
@@ -329,15 +322,11 @@ extension GenericRTPoint: GenericRTNode {
 }
 
 @JS func describeRefinedEntity(_ entity: RefineEntity) -> String {
-    // `id` and `label()` resolve to RefineEntity's extension (most specific);
-    // `score` and its setter come from RefineIdentified's.
     var identified: any RefineIdentified = entity
     identified.score = entity.score + 1
     return "\(entity.id):\(entity.name):\(entity.label()):\(identified.score)"
 }
 
-// A refining protocol with no requirements of its own emits no extension;
-// its wrapper still conforms through the parents' extensions.
 @JS protocol RefineTagged: RefineEntity {}
 
 @JS func describeTaggedEntity(_ entity: RefineTagged) -> String {

Tests/prelude.mjs

@@ -301,9 +301,6 @@ function BridgeJSRuntimeTests_runJsWorks(instance, exports) {
     const optDict = { hello: "world" };
     assert.deepEqual(exports.roundTripOptionalDictionaryExport(optDict), optDict);
     assert.equal(exports.roundTripOptionalDictionaryExport(null), null);
-    // @JS protocol refinement: one JS object satisfies the refined protocol
-    // and both of its parents; the Swift side reads inherited members and
-    // writes the inherited settable one.
     const entity = { id: "e1", name: "Main", score: 10, label() { return "L" + this.score; } };
     assert.equal(exports.describeRefinedEntity(entity), "e1:Main:L11:11");
     assert.equal(entity.score, 11);