[make:controller][make:crud] Make route names start with 'app_' (#1007)

* [make:controller][make:crud] Make route names start with 'app_'

* Use the more appropriate 'asSnakeCase()' method to resolve the service id

Author: robmeijer

src/Str.php

@@ -102,7 +102,9 @@ public static function asRoutePath(string $value): string
 
     public static function asRouteName(string $value): string
     {
-        return self::asTwigVariable($value);
+        $routeName = self::asTwigVariable($value);
+
+        return str_starts_with($routeName, 'app_') ? $routeName : 'app_'.$routeName;
     }
 
     public static function asSnakeCase(string $value): string

src/Test/MakerTestCase.php

@@ -106,7 +106,7 @@ private function getMakerInstance(string $makerClass): MakerInterface
         }
 
         // a cheap way to guess the service id
-        $serviceId = $serviceId ?? sprintf('maker.maker.%s', Str::asRouteName((new \ReflectionClass($makerClass))->getShortName()));
+        $serviceId = $serviceId ?? sprintf('maker.maker.%s', Str::asSnakeCase((new \ReflectionClass($makerClass))->getShortName()));
 
         return $this->kernel->getContainer()->get($serviceId);
     }

tests/StrTest.php

@@ -200,4 +200,19 @@ public function asHumanWordsTests()
         yield [' FooBar', 'Foo Bar'];
         yield [' Foo Bar ', 'Foo Bar'];
     }
+
+    /**
+     * @dataProvider provideAsRouteName
+     */
+    public function testAsRouteName(string $value, string $expectedRouteName)
+    {
+        $this->assertSame($expectedRouteName, Str::asRouteName($value));
+    }
+
+    public function provideAsRouteName()
+    {
+        yield ['Example', 'app_example'];
+        yield ['AppExample', 'app_example'];
+        yield ['Apple', 'app_apple'];
+    }
 }