ams: remove unused message-size macros

AMS_MESSAGE_SIZE() and AMS_SLOT_SIZE() assumed the message payload was
stored inline after the header, but ams_message_payload.message is a
pointer to a caller-owned buffer (set in ams_helper_prepare_payload) and
the slot only carries the fixed-size struct. The last use of
AMS_MESSAGE_SIZE() was replaced by sizeof(*msg); AMS_SLOT_SIZE() had no
users. Remove both as dead and misleading.

Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>

Author: lrgirdwo

src/include/sof/lib/ams.h

@@ -29,10 +29,6 @@
 /* Space allocated for async message content*/
 #define AMS_MAX_MSG_SIZE 0x1000
 
-/* Size of slots message, module id and instance id */
-#define AMS_SLOT_SIZE(msg) (AMS_MESSAGE_SIZE(msg) + sizeof(uint16_t) * 2)
-#define AMS_MESSAGE_SIZE(msg) (sizeof(*msg) - sizeof(char) + (sizeof(char) * (msg->message_length)))
-
 /**
  * \brief IXC message payload
  *

src/lib/ams.c

@@ -284,10 +284,9 @@ static uint32_t ams_push_slot(struct ams_shared_context __sparse_cache *ctx_shar
 
 	for (uint32_t i = 0; i < ARRAY_SIZE(ctx_shared->slots); ++i) {
 		if (ctx_shared->slot_uses[i] == 0) {
-			/* the slot stores the payload struct (read back via
-			 * u.msg); AMS_MESSAGE_SIZE() adds message_length, which
-			 * over-reads past the struct since message is a pointer,
-			 * not inline data
+			/* the slot only carries the payload struct (read back
+			 * via u.msg); message points to a caller-owned buffer
+			 * rather than inline data, so copy exactly the struct
 			 */
 			err = memcpy_s((__sparse_force void *)ctx_shared->slots[i].u.msg_raw,
 				       sizeof(ctx_shared->slots[i].u.msg_raw),