dax: set instance lifespan from prepare to reset #10503

johnylin76 · 2026-02-02T08:00:25Z

tuning_file_buffer should not be released by destroy_instance (or implements a way to recover the buffer data on establishment). Move to sof_dax_free

checkupup · 2026-01-30T04:07:28Z

Since only persist and scratch buffers are allocated during entablishment phase, we could be only responsible for releasing them during the destruction phase:

static void destroy_instance(struct processing_module *mod) { struct sof_dax *dax_ctx = module_get_private_data(mod); dax_free(dax_ctx); dax_buffer_release(mod, &dax_ctx->persist_buffer); dax_buffer_release(mod, &dax_ctx->scratch_buffer); }

checkupup · 2026-01-30T04:13:49Z

if sof_dax_reset can always be called before sof_dax_free phase, destruction may be not necessary here.

Theoretically yes, but I don't feel we should rely on that assumption.

The memory free() function of C causes no harm if the input pointer is null. Your dax_buffer_release() implementation is handled well so they are good to be called more than once.

My only concern is that I am not sure if calling dax_free() twice is also good because this is a private call

if so, following releases are also required here:

dax_buffer_release(mod, &dax_ctx->tuning_file_buffer); dax_buffer_release(mod, &dax_ctx->input_buffer); dax_buffer_release(mod, &dax_ctx->output_buffer);

dax_free() is safe for multiple frees.

checkupup · 2026-01-30T04:21:03Z

It might be better to place establish_instance after check_media_format to avoid unnecessary destruction if check_media_format fails.
On the other side, we need to add the option CONFIG_IDC_TIMEOUT_US=50000 to the file app/overlays/[ptl/mtl]/dax_overlay.conf to avoid IPC_TIMEOUT errors， because dax_init takes more than 20 ms, exceeding default IDC_TIMEOUT value (10ms).

That's also I worried about. But I don't get why dax_init() takes so long because at that moment DAX didn't even get the configuration data (from dax_param.bin). Or does DAX make the advance calculation on dax_init() such as configuration prediction?

We have verified without changing CONFIG_IDC_TIMEOUT_US and didn't get timeout problem (I assume the timeout should lead to a stable failure if it really cares). Could you check with that?

You can set DOLBY_DAX_CORE_ID as 1 (or other different cores with pipeline) to trigger IDC timer.
dax_init will perform a large number of initialization operations based on the provided memory and load some static data.

I see. You are correct "IDC" is for the inter-CPU communication.

As for dax_init(), do you mean "loading static data" to memory allocated on runtime for speeding the later computation? I remember we didn't use DRAM for ADSP in the current device so it still sounds weird to me.

my bad for clarifying this.This refers to loading static data from RAM (decalared as static arrays and stored in .data section) into runtime buffer and performing initializations for features in it.

checkupup · 2026-01-30T04:36:29Z

Simultaneously release following buffers here:

dax_buffer_release(mod, &dax_ctx->tuning_file_buffer); dax_buffer_release(mod, &dax_ctx->input_buffer); dax_buffer_release(mod, &dax_ctx->output_buffer);

Becasue these buffers are also allocated in sof_dax_prepare. If a lifecycle of dax instance is from prepare to reset phrase, then I believe that all resources created in sof_dax_prepare should have the same lifecycle.

Yes. The better practice is releasing all runtime buffers when reset.

-Original file line number
+Diff line change
@@ Expand Up @@
     	}
     }
-    static int sof_dax_free(struct processing_module *mod)
+    static void destroy_instance(struct processing_module *mod)
     {
     	struct sof_dax *dax_ctx = module_get_private_data(mod);
@@ Expand All / @@ -476,6 +476,51 @@ static int sof_dax_free(struct processing_module *mod) @@
     		dax_buffer_release(mod, &dax_ctx->tuning_file_buffer);
     		dax_buffer_release(mod, &dax_ctx->input_buffer);
     		dax_buffer_release(mod, &dax_ctx->output_buffer);
+    	}
+    }
+    static int establish_instance(struct processing_module *mod)
+    {
+    	int ret = 0;
+    	struct comp_dev *dev = mod->dev;
+    	struct sof_dax *dax_ctx = module_get_private_data(mod);
+    	uint32_t persist_sz;
+    	uint32_t scratch_sz;
+    	persist_sz = dax_query_persist_memory(dax_ctx);
+    	if (dax_buffer_alloc(mod, &dax_ctx->persist_buffer, persist_sz) != 0) {
+    		comp_err(dev, "allocate %u bytes failed for persist", persist_sz);
+    		ret = -ENOMEM;
+    		goto err;
+    	}
+    	scratch_sz = dax_query_scratch_memory(dax_ctx);
+    	if (dax_buffer_alloc(mod, &dax_ctx->scratch_buffer, scratch_sz) != 0) {
+    		comp_err(dev, "allocate %u bytes failed for scratch", scratch_sz);
+    		ret = -ENOMEM;
+    		goto err;
+    	}
+    	ret = dax_init(dax_ctx);
+    	if (ret != 0) {
+    		comp_err(dev, "dax instance initialization failed, ret %d", ret);
+    		goto err;
+    	}
+    	comp_info(dev, "allocated: persist %u, scratch %u. version: %s",
+    		  persist_sz, scratch_sz, dax_get_version());
+    	return 0;
+    err:
+    	destroy_instance(mod);
+    	return ret;
+    }
+    static int sof_dax_free(struct processing_module *mod)
+    {
+    	struct sof_dax *dax_ctx = module_get_private_data(mod);
+    	destroy_instance(mod);
+    	if (dax_ctx) {
     		mod_data_blob_handler_free(mod, dax_ctx->blob_handler);
     		dax_ctx->blob_handler = NULL;
     		mod_free(mod, dax_ctx);
@@ Expand All / @@ -486,12 +531,9 @@ static int sof_dax_free(struct processing_module *mod) @@
     static int sof_dax_init(struct processing_module *mod)
     {
-    	int ret;
     	struct comp_dev *dev = mod->dev;
     	struct module_data *md = &mod->priv;
     	struct sof_dax *dax_ctx;
-    	uint32_t persist_sz;
-    	uint32_t scratch_sz;
     	md->private = mod_zalloc(mod, sizeof(struct sof_dax));
     	if (!md->private) {
@@ Expand All / @@ -511,35 +553,12 @@ static int sof_dax_init(struct processing_module *mod) @@
     	dax_ctx->blob_handler = mod_data_blob_handler_new(mod);
     	if (!dax_ctx->blob_handler) {
     		comp_err(dev, "create blob handler failed");
-    		ret = -ENOMEM;
-    		goto err;
-    	}
-    	persist_sz = dax_query_persist_memory(dax_ctx);
-    	if (dax_buffer_alloc(mod, &dax_ctx->persist_buffer, persist_sz) != 0) {
-    		comp_err(dev, "allocate %u bytes failed for persist", persist_sz);
-    		ret = -ENOMEM;
-    		goto err;
-    	}
-    	scratch_sz = dax_query_scratch_memory(dax_ctx);
-    	if (dax_buffer_alloc(mod, &dax_ctx->scratch_buffer, scratch_sz) != 0) {
-    		comp_err(dev, "allocate %u bytes failed for scratch", scratch_sz);
-    		ret = -ENOMEM;
-    		goto err;
-    	}
-    	ret = dax_init(dax_ctx);
-    	if (ret != 0) {
-    		comp_err(dev, "dax instance initialization failed, ret %d", ret);
-    		goto err;
+    		mod_free(mod, dax_ctx);
+    		module_set_private_data(mod, NULL);
+    		return -ENOMEM;
     	}
-    	comp_info(dev, "allocated: persist %u, scratch %u. version: %s",
-    		  persist_sz, scratch_sz, dax_get_version());
     	return 0;
-    err:
-    	sof_dax_free(mod);
-    	return ret;
     }
     static int check_media_format(struct processing_module *mod)
@@ Expand Down Expand Up @@
     		return -EINVAL;
     	}
+    	/* dax instance will be established on prepare(), and destroyed on reset() */
+    	ret = establish_instance(mod);
+    	if (ret != 0)
+    		return ret;
     	ret = check_media_format(mod);
     	if (ret != 0)
     		return ret;
@@ Expand Down Expand Up @@
     	return ret;
     }
+    static int sof_dax_reset(struct processing_module *mod) {
+    	struct comp_dev *dev = mod->dev;
+    	/* dax instance will be established on prepare(), and destroyed on reset() */
+    	destroy_instance(mod);
+    	comp_info(dev, "reset");
+    	return 0;
+    }
     static const struct module_interface dolby_dax_audio_processing_interface = {
     	.init = sof_dax_init,
     	.prepare = sof_dax_prepare,
     	.process = sof_dax_process,
     	.set_configuration = sof_dax_set_configuration,
+    	.reset = sof_dax_reset,
     	.free = sof_dax_free,
     };
@@ Expand Down @@

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dax: set instance lifespan from prepare to reset #10503

Diff view

Diff view

There are no files selected for viewing

johnylin76 Feb 2, 2026

Uh oh!

checkupup Jan 30, 2026 •

edited

Loading

Uh oh!

checkupup Jan 30, 2026 •

edited

Loading

Uh oh!

johnylin76 Jan 30, 2026

Uh oh!

checkupup Jan 30, 2026

Uh oh!

checkupup Jan 30, 2026 •

edited

Loading

Uh oh!

johnylin76 Jan 30, 2026

Uh oh!

checkupup Jan 30, 2026

Uh oh!

johnylin76 Jan 30, 2026

Uh oh!

checkupup Feb 2, 2026

Uh oh!

checkupup Jan 30, 2026

Uh oh!

johnylin76 Jan 30, 2026

Uh oh!

Uh oh!

dax: set instance lifespan from prepare to reset #10503

Are you sure you want to change the base?

dax: set instance lifespan from prepare to reset #10503

Uh oh!

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Choose a reason for hiding this comment

Uh oh!

checkupup Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

checkupup Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

checkupup Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

checkupup Jan 30, 2026 •

edited

Loading

checkupup Jan 30, 2026 •

edited

Loading

checkupup Jan 30, 2026 •

edited

Loading