-
Notifications
You must be signed in to change notification settings - Fork 190
Make UI.wrapperElement non-public by adding private field and public getter #22016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@mshabarov 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
…getter Co-authored-by: mshabarov <[email protected]>
Format Checker Report
Here is the list of files with format issues in your PR: |
|




The
wrapperElementfield in theUIclass was incorrectly declared aspublic, which violates encapsulation principles and exposes internal implementation details.This PR addresses the issue by:
public Element wrapperElement;toprivate Element wrapperElement;public Element getWrapperElement()method with proper JavaDoc documentationChanges Made
ui.getWrapperElement()Benefits
The
wrapperElementis used as a container for route components when client-side routing is enabled, and this refactoring ensures it follows proper object-oriented design principles while maintaining full backward compatibility.Fixes #22008.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
maven.vaadin.com/usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.11/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.11/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.11 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.11/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/flow/flow org.codehaus.plexus.classworlds.launcher.Launcher compile -q(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.