fix: stablize jrejsmap in flow-client #22869
Open
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #22767
This PR together with some previous ones should resolve all the flaky tests currently found in the flow repo. Here the non-deterministic test is
JreMapTest.testMapValuesinflow-client.Root Cause
The non-deterministic is from
for (Entry<K, V> entry : values.entrySet())iteration in JRE Map'sforEachmethod. The assertion in the test assumes it preserves the insertion order.Fix
Switched
HashMaptoLinkedHashMapso iteration order preserves insertion order just like JavaScript Map. We can choose to relax the assertion instead, but considering this is a fallback for JavaScript Map, we try to follow its behavior.Note
This is the last PR for the issue #22767. If this is accepted I will close the issue.
Type of change
Checklist
Additional for
Featuretype of change