Skip to content

Commit 31d37d9

Browse files
authored
use negate flag parser in ft.info parser (#524)
Signed-off-by: Miles Song <[email protected]>
1 parent 990efa0 commit 31d37d9

File tree

1 file changed

+4
-16
lines changed

1 file changed

+4
-16
lines changed

src/commands/ft_info_parser.cc

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -56,29 +56,17 @@ vmsdk::KeyValueParser<InfoCommand> CreateInfoParser() {
5656
return absl::OkStatus();
5757
}));
5858

59-
// TODO: GENERATE_NEGATE_FLAG_PARSER in FT.SEARCH PR
60-
parser.AddParamParser(
61-
"ALLSHARDS",
62-
std::make_unique<vmsdk::ParamParser<InfoCommand>>(
63-
[](InfoCommand &cmd, vmsdk::ArgsIterator &itr) -> absl::Status {
64-
cmd.enable_partial_results = false;
65-
return absl::OkStatus();
66-
}));
59+
parser.AddParamParser("ALLSHARDS", GENERATE_NEGATED_FLAG_PARSER(
60+
InfoCommand, enable_partial_results));
6761

6862
parser.AddParamParser(
6963
"SOMESHARDS", GENERATE_FLAG_PARSER(InfoCommand, enable_partial_results));
7064

7165
parser.AddParamParser("CONSISTENT",
7266
GENERATE_FLAG_PARSER(InfoCommand, require_consistency));
7367

74-
// TODO: GENERATE_NEGATE_FLAG_PARSER in FT.SEARCH PR
75-
parser.AddParamParser(
76-
"INCONSISTENT",
77-
std::make_unique<vmsdk::ParamParser<InfoCommand>>(
78-
[](InfoCommand &cmd, vmsdk::ArgsIterator &itr) -> absl::Status {
79-
cmd.require_consistency = false;
80-
return absl::OkStatus();
81-
}));
68+
parser.AddParamParser("INCONSISTENT", GENERATE_NEGATED_FLAG_PARSER(
69+
InfoCommand, require_consistency));
8270

8371
return parser;
8472
}

0 commit comments

Comments
 (0)