Fix replica crash by using legacy ACL path during replication #510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify AclPrefixCheck to use the new fast ACL API only for real user clients. During replication context, fall back to the legacy ACL path which has proper safety checks and prevents segmentation fault in VM_GetModuleUserFromUserName. This approach: - Preserves fast ACL checking for real users when new API is available - Uses safe legacy path during replication/AOF/internal operations - Prevents crashes while maintaining performance benefits Fixes crash introduced in commit e9f277c when ACL checking was added.
yairgott
approved these changes
Dec 1, 2025
yairgott
reviewed
Dec 2, 2025
I, Elias Tamraz <[email protected]>, hereby add my Signed-off-by to this commit: 0384de5 Address code review feedback: - Add early return for non-real users to avoid unnecessary work - Replace conditional check with assertion for better error handling Co-authored-by: yairgott Signed-off-by: Elias Tamraz <[email protected]>
yairgott
approved these changes
Dec 2, 2025
Collaborator
Author
|
@yairgott anything pending here ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #509