pytest_plugin(fix[skip_if_svn_missing]): Require svnadmin too

why: The svn fixtures build repositories with `svnadmin`, and
_skip_if_svn_missing() treats svn as available only when both the svn
client and svnadmin are present. The public skip_if_svn_missing mark and
the pytest_ignore_collect hook checked the svn client alone, so on a
host with svn but not svnadmin they disagreed with the fixtures: a
mark-decorated test would run, and svn doctest modules would be
collected while their create_svn_remote_repo namespace helper -- which
also requires svnadmin -- was withheld, erroring with NameError instead
of skipping. Make every svn-availability check require svnadmin.

what:
- Add the svnadmin check to the skip_if_svn_missing mark condition
- Require svnadmin in pytest_ignore_collect so svn modules are ignored
  (not collected) when only the svn client is present

Author: tony

src/libvcs/pytest_plugin.py

@@ -34,8 +34,8 @@ def __init__(self, attempts: int, *args: object) -> None:
     reason="git is not available",
 )
 skip_if_svn_missing = pytest.mark.skipif(
-    not shutil.which("svn"),
-    reason="svn is not available",
+    not shutil.which("svn") or not shutil.which("svnadmin"),
+    reason="svn or svnadmin is not available",
 )
 skip_if_hg_missing = pytest.mark.skipif(
     not shutil.which("hg"),
@@ -52,7 +52,7 @@ def _skip_if_git_missing() -> None:
 def _skip_if_svn_missing() -> None:
     """Skip the calling fixture when ``svn`` or ``svnadmin`` is unavailable."""
     if not shutil.which("svn") or not shutil.which("svnadmin"):
-        pytest.skip(reason="svn is not available")
+        pytest.skip(reason="svn or svnadmin is not available")
 
 
 def _skip_if_hg_missing() -> None:
@@ -121,7 +121,7 @@ def __next__(self) -> str:
 
 def pytest_ignore_collect(collection_path: pathlib.Path, config: pytest.Config) -> bool:
     """Skip tests if VCS binaries are missing."""
-    if not shutil.which("svn") and any(
+    if (not shutil.which("svn") or not shutil.which("svnadmin")) and any(
         needle in str(collection_path) for needle in ["svn", "subversion"]
     ):
         return True