`pack` options are not recoginzed in `defineProject`

[silen-z]

Describe the bug

Given this vite.config.ts in monorepo subpackage:

import { defineProject } from "vite-plus";

export default defineProject({
  pack: {
    entry: ["src/index.ts"],
    format: ["esm"],
  },
});

vp check reports this error:

× typescript(TS2769): No overload matches this call.
   ╭─[packages/nested/vite.config.ts:4:3]
 3 │ export default defineProject({
 4 │   pack: {
   ·   ────
 5 │     entry: ["src/index.ts"],
   ╰────

also pack in vite.config.ts in project root, reports no errors.

I also used to hit this error in my full project with more configuration:

  × typescript(TS2321): Excessive stack depth comparing types '{ enabled: true; provider: BrowserProviderOption<PlaywrightProviderOptions>; headless: true; instances: { browser: string; }[]; screenshotFailures: false; }' and 'BrowserConfigOptions | undefined'.

I think they might be related. This Excessive stack depth comparing types error would not always happen and it could complain about different parts of the config here its test options, but I also saw it complain about plugins in pack

But as I removed stuff to create minimal repro only the former error remained.

Reproduction

https://github.com/silen-z/vp-bug-repro

Steps to reproduce

run 'pnpm install' and vp check

System Info

vp v0.2.1

Local vite-plus:
  vite-plus  v0.2.1

Tools:
  vite             v8.0.16
  rolldown         v1.1.1
  vitest           v4.1.9
  oxfmt            v0.55.0
  oxlint           v1.70.0
  oxlint-tsgolint  v0.23.0
  tsdown           v0.22.3

Used Package Manager

pnpm

Logs

Validations

• Read the Contributing Guidelines.
• Check that there isn't already an issue for the same bug.
• Confirm this is a Vite+ issue and not an upstream issue (Vite, Vitest, tsdown, Rolldown, or Oxc).
• The provided reproduction is a minimal reproducible example.

[jong-kyung]

Thanks for the repro. This config should use defineConfig, not defineProject.

defineProject is the Vitest project-config helper, mainly for configs loaded through test.projects. Vite+ top-level tool options such as pack, lint, fmt, run, and staged belong in defineConfig.

import { defineConfig } from "vite-plus";

export default defineConfig({
  pack: {
    entry: ["src/index.ts"],
    format: ["esm"],
  },
});

So this is expected from the current typing rather than a pack bug.

Related context:

• https://viteplus.dev/guide/migrate-rules#source-rewrite-rules
• https://vitest.dev/guide/projects.html#defining-projects

cc. @fengmk2

[silen-z]

Oh no, I totally missed that. It worked for a few past versions so it never occurred to me I'm using the wrong config function (it might have even been generated by vp migrate).

After fixing the issue in my project I'm still sometimes hitting Excessive stack depth comparing types when typechecking the config. I narrowed it down to Solid plugin from vite-plugin-solid. When I cast its type via as to Plugin exported from vite-plus the error goes away. But that's probably another issue with the plugin not being updated and using another vite version.