Remove unused GhRepo starter type #3346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cprecioso
temporarily deployed
to
fly-deploy-test
GitHub Actions
Inactive
This was referenced Nov 10, 2025
cprecioso
changed the title
13 tasks
cprecioso
force-pushed
the
cprecioso/remove-gh-repo
branch
from
2c17b14 to
2a0dd61
Compare
cprecioso
temporarily deployed
to
fly-deploy-test
GitHub Actions
Inactive
Deploying wasp-docs-on-main with
|
| Latest commit: |
2a0dd61
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://76a77b3a.wasp-docs-on-main.pages.dev |
| Branch Preview URL: | https://cprecioso-remove-gh-repo.wasp-docs-on-main.pages.dev |
sodic
requested changes
Nov 11, 2025
cprecioso
temporarily deployed
to
fly-deploy-test
GitHub Actions
Inactive
Member
Author
|
@sodic You're right. I was counting on the HLS to grey out unused definitions, but didn't realize that we have a |
cprecioso
temporarily deployed
to
fly-deploy-test
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #3196 I removed all the templates that used the
StarterTemplates.GhRepoconstructor. I didn't remove the constructor and its handling "in case we needed it in the future". This is not clean code. We should remove it! We can bring it back with Git if we need it.Connections
Followup to Use pre-built tarballs for
wasp new -t saas#3196Working towards
open-saasdevelopment version is out of sync withwaspdevelopment version #3073Part of WIP: Add local template option #3338 -- I split the refactors into their own PRs for ease of review:
Type of change
Checklist
I tested my change in a Wasp app to verify that it works as intended.
🧪 Tests:
I added unit tests for my change.(if you fixed a bug) I added a regression test for the bug I fixed.(if you added/updated a feature) I added/updated e2e tests atexamples/kitchen-sink/e2e-tests.(if you added/updated a feature) I updated the starter templates atwaspc/data/Cli/templates, as needed.📜 Documentation:
(if you added/updated a feature) I added/updated the documentation inweb/docs/.🆕 Changelog: (if change is more than just code/docs improvement)
I updatedwaspc/ChangeLog.mdwith a user-friendly description of the change.(if you did a breaking change) I added a step to the current migration guide atweb/docs/migration-guides/.I bumped theversioninwaspc/waspc.cabalto reflect the changes I introduced.