Skip to content

History limit removes the newest command, not the oldest #34

Open
#32
Open
History limit removes the newest command, not the oldest#34
#32

Description

@RReverser
RReverser
opened on Oct 9, 2020

This:

local-echo/lib/HistoryController.js

Lines 22 to 24 in 8d0b7f5

if (this.entries.length > this.size) {
this.entries.pop(0);
}

should've been using .shift(). Instead, current behaviour keeps pushing one item into the history and immediately popping it back, so that once limit is reached, no history items are stored.

Activity

  1. RReverser
    added a commit that references this issue on Oct 9, 2020

    Fix history limit handling

    e09efbb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions