feat: multiple media selection on Drive conversations - WPB-24046#4613
Conversation
…e uploaded asset after editing (wip)
…rom picker, handle media edition, fix issue on tap.
Test Results4 552 tests 4 525 ✅ 7m 40s ⏱️ Results for commit 35d830e. ♻️ This comment has been updated with latest results. Summary: workflow run #25305822495 |
…m/wireapp/wire-ios into feat/drive-multiple-media-selection
johnxnguyen
left a comment
There was a problem hiding this comment.
Looks good, left a couple questions.
OlivellaO
left a comment
There was a problem hiding this comment.
Approved with question
…ed drafts uploads (native picker) adjust send button in edition screen
WilhelmOks
left a comment
There was a problem hiding this comment.
LGTM. Added a few comments.
…m/wireapp/wire-ios into feat/drive-multiple-media-selection
Test Results – WireMessagingAll303 tests 303 ✅ 1m 24s ⏱️ Results for commit 12fa484. ♻️ This comment has been updated with latest results. |
Test Results – Wire-iOS1 879 tests 1 852 ✅ 2m 2s ⏱️ Results for commit 12fa484. ♻️ This comment has been updated with latest results. |
|
@netbe @johnxnguyen @WilhelmOks @OlivellaO FYI, I made some improvements / fixes following the PT, these are visible in this single commit: 700d393
Feel free to review it if you want. |
Test Results – WireUIAll161 tests 160 ✅ 58s ⏱️ Results for commit 12fa484. ♻️ This comment has been updated with latest results. |
Test Results – WireDataModel2 377 tests 2 377 ✅ 4m 38s ⏱️ Results for commit 12fa484. ♻️ This comment has been updated with latest results. |
|



Issue
Currently user has to select each image from the gallery (custom and native one) one by one and approve it in full screen view.
This PR introduces changes to allow the user to frictionlessly upload multiple media at once.
Overview
PHPickerViewControlleris introduced to allow multiple media selection (previouslyUIImagePickerControllerwas used)Testing
Wire drive conversations
Non-Wire drive conversations (non regression test)
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: