Skip to content

There are uncaught exceptions in connector.py #37

@jkugler

Description

@jkugler

Connector._session_login() and Connector._basic_login() methods call self._client.METHOD() instead of self._METHOD() and don't catch requests.exceptions.ConnectionError, passing it up to the caller. To fix, they should call self._post() and self._get(), respectively.

Connector._request does catch ConnectionError, BUT it doesn't put a try around the retry. It should just call itself (maybe with a counter to avoid run away).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions